Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JaxRS*] javax.ws.rs.core.Response vs. returnTypes #4713

Open
2 of 8 tasks
jfiala opened this issue Feb 4, 2017 · 3 comments
Open
2 of 8 tasks

[JaxRS*] javax.ws.rs.core.Response vs. returnTypes #4713

jfiala opened this issue Feb 4, 2017 · 3 comments
Labels
Enhancement: General help wanted Server: Java
Milestone
Future

Comments

@jfiala
Copy link
Contributor

jfiala commented Feb 4, 2017 •
edited
Loading

Description

Currently only the language jaxrs-cxf returns the "real" returnType in the method signatures as opposed to the generic javax.ws.rs.core.Response. All other Jaxrs-languages use javax.ws.rs.core.Response.

IMHO all JaxRS-languages should allow a CLI-flag ("useGenericJaxRsResponse", default value=true for backwards compatibility) whether to use the generic javax.ws.rs.core.Response or the real returnTypes in the method signatures.

Languages to be updated:

  • jaxrs-cxf-cdi
  • jaxrs-spec
  • jaxrs (Jersey)
  • jaxrs-cxf
    CXF already has the check, but no CLI flag to use the Jaxrs-Response

I added the check for the CLI-flag useGenericResponse

  • jaxrs-cxf-client

I added the check for the CLI-flag useGenericResponse

  • jaxrs-resteasy
  • java
  • spring
Swagger-codegen version

2.2.2
This was referenced Feb 4, 2017
Open
Open
@MatanRubin
Copy link
Contributor

+1, would be great

@jfiala jfiala mentioned this issue Feb 12, 2017
Merged
3 tasks
@jfiala
Copy link
Contributor Author

jfiala commented Feb 12, 2017

@MatanRubin implemented the check for cxf (server) + cxf-client, pls review and if OK I'll update the other languages.

@wing328 wing328 added this to the v2.2.3 milestone Feb 23, 2017
@jfiala jfiala mentioned this issue Mar 5, 2017
Closed
jfiala added a commit to jfiala/swagger-codegen that referenced this issue Mar 9, 2017
@jfiala
move check for genericresponse to cxf codegen swagger-api#4713
6a67a53
wing328 pushed a commit that referenced this issue Apr 2, 2017
@jfiala @wing328
[Jaxrs-cxf] Add check for useGenericResponse for jaxrs-cxf server + c…
ca6b5d0 
…lient (#4779)

* add check for useGenericResponse for jaxrs-cxf

* move check for genericresponse to cxf codegen #4713
davidgri pushed a commit to davidgri/swagger-codegen that referenced this issue May 11, 2017
@jfiala @wing328
[Jaxrs-cxf] Add check for useGenericResponse for jaxrs-cxf server + c…
33a9c83 
…lient (swagger-api#4779)

* add check for useGenericResponse for jaxrs-cxf

* move check for genericresponse to cxf codegen swagger-api#4713
@wing328 wing328 modified the milestones: v2.2.3, v2.3.0 Jul 16, 2017
@wing328 wing328 modified the milestones: Future, v2.3.0 Jul 26, 2017
@shuawest shuawest mentioned this issue Jan 19, 2018
Open
@kaveenr
Copy link

kaveenr commented Jan 12, 2019

Can this feature be used with the swagger-codegen-maven-plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement: General help wanted Server: Java
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@wing328 @kaveenr @jfiala @MatanRubin