Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAXRS-CXF-CDI] Add a new JAX-RS server generator - jaxrs-cxf-cdi #3940

Merged
merged 4 commits into from
Oct 10, 2016

Conversation

nickcmaynard
Copy link
Contributor

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Generate a JAX-RS server that assumes an Apache CXF framework on a Java EE server supporting CDI.

Similar to the original JAXRS generator, this creates API and Service classes in /src/gen/java and a sample ServiceImpl in /src/main/java. The API uses CDI to get an instance of ServiceImpl that implements the Service interface.

@nickcmaynard
Copy link
Contributor Author

... this one should do the "right thing" with the PR template.

@wing328 wing328 added this to the v2.2.2 milestone Oct 6, 2016
@nickcmaynard
Copy link
Contributor Author

Happy to update the wiki (if possible) once merged.

@wing328
Copy link
Contributor

wing328 commented Oct 7, 2016

@nickcmaynard thanks for the PR. I'll review this weekend and let you know if I've any question.

@wing328
Copy link
Contributor

wing328 commented Oct 10, 2016

@nickcmaynard it looks good. Later I'll file a PR to change the indentation from tab to 4-space for JavaJAXRSCXFCDIServerCodegen as well as JavaJAXRSSpecServerCodegen.

@wing328 wing328 merged commit dc2b8c2 into swagger-api:master Oct 10, 2016
@wing328
Copy link
Contributor

wing328 commented Oct 10, 2016

@nickcmaynard I've updated the documentation here: https://github.com/swagger-api/swagger-codegen/wiki/Server-stub-generator-HOWTO#java-jax-rs-apache-cxf-framework-on-java-ee-server-supporting-cdi

It would be nice if the generator can create a pom.xml and README.md explaining a bit about the auto-generated code.

@nickcmaynard
Copy link
Contributor Author

Great news thank you. I'll look into a pom.xml and README in a separate PR.

acramatte added a commit to comerge/swagger-codegen that referenced this pull request Oct 12, 2016
* upstream/master:
  [html]Group api index by operations.baseName (swagger-api#3953)
  Revert "[WIP] Improve PHP client emitted code quality"
  update retrofit1,2 samples
  jaxrs-cxf-cdi POM template (swagger-api#3958)
  [Swift] Add / as enum separator
  issue-890 correct fix for deprecated Jersey method
  2208 fix Objc Mapping Generation (swagger-api#3894)
  [Spring] Format datetime in rfc3339 (swagger-api#3777)
  [Java/Jackson] use a jdk6 compatible DateFormat for java.util.Date (swagger-api#3768)
  add template owner jax-rs cxf cdi
  remove newline char in *.mustache; added generated code
  Add a new JAX-RS server generator - jaxrs-cxf-cdi (swagger-api#3940)
  added package paths for retrofit class names
  feature(PHP QA) add initial PHP client template tweaks to improve emitted code quality
  [resteasy] configure jackson to use rfc3339 dates
  [jersey] configure jackson to use rfc3339 dates
@wing328
Copy link
Contributor

wing328 commented Oct 16, 2016

Tweet: https://twitter.com/wing328/status/787670177785585664

To all, please help retweet to promote the new generator. Thank you.

@wing328 wing328 changed the title Add a new JAX-RS server generator - jaxrs-cxf-cdi [JAXRS-CXF-CDI] Add a new JAX-RS server generator - jaxrs-cxf-cdi Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants