[JaxrsResteasy] Improvements for Resteasy for Jboss EAP 4512 #4712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfiala
changed the title
10 tasks
|
Finished all the requirements of #4512 so far. Please let me know if I should also generate sample output for java8 datetime support (currently there are only sample outputs for joda). |
|
@wing328 Can we have this for 2.2.2? I provided a customer of mine with templates for this, but I would like to have this in the release. |
|
@jfiala let me review first... |
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
…-api#4712) * add language for resteasy eap swagger-api#4512 * first implementation of jaxrs-resteasy-eap swagger-api#4512 * add support for joda and java8 datetime types swagger-api#4512 * add new file JacksonConfig and new sample eap-joda swagger-api#4512 * add dynamic swagger support to jaxrs-resteasy-eap swagger-api#4512 * adapt readme for eap swagger-api#4512 * add tests for jaxrs-resteasy-eap swagger-api#4512 * cleanup tabs swagger-api#4512 * cleanup tabs swagger-api#4512 * cleanup tabs swagger-api#4512 * cleanup tabs / regenerate without joda swagger-api#4512 * regenerate with updated templates swagger-api#4512 * fix test (wrong setter invoked) swagger-api#4512 * fix test swagger-api#4512 * fix no invocation swagger-api#4512 * replace tabs with spaces swagger-api#4512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
First draft adaption of the jaxrs-resteasy language, for details see #4512
I created a new language jaxrs-resteasy-eap so this change can make it into 2.2.2.
With 2.3.0 this language could replace the existing jaxrs-resteasy.
The new samples are generated to samples/server/petstore/jaxrs-resteasy/eap and eap-joda to separate it from jaxrs-resteasy paths (default/joda-time).
The WAR file was verified to run on Jboss EAP 6 and 7.
This language supports Java8 and Joda datetime using the JacksonConfig, the needed dependencies included automatically (see pom.mustache).
I added the flag "joda" to AbstractJavaCodegen.java to allow checking for joda in the mustache templates.
I also added the option to generate the Swagger contract dynamically (useSwaggerFeature).
New test including the useSwaggerFeature: JavaResteasyEapServerOptionsTest.java