[Python] Binary mode for file deserialization #6936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thanks for the contribution @g-bon |
|
@g-bon thanks for the fix. @kenjones-cisco thanks for reviewing the change. |
wing328
changed the title
|
Thanks to you for reviewing the change. |
jimschubert
added a commit
to jimschubert/swagger-codegen
that referenced
this pull request
Nov 14, 2017
* master: (101 commits) [Swift4] Allow for custom dateformatter to be used (swagger-api#6672) [haskell-http-client] fix bug when generating models-only (swagger-api#6931) fix typo: crediential => credential minor typo fix [csharp] fix enum serialization of first value (swagger-api#6873) [PHP] Improve docs and README (swagger-api#6935) Binary mode for file deserialization in python (swagger-api#6936) add python tornado test to travis [Python/tornado] add integration tests and fix bugs (swagger-api#6925) Fix PHP passes response body to ApiException (swagger-api#6923) [TypeScript][Node] Resolve TS2532 error (swagger-api#6932) skip "all" shell script minor formatting change Fixes Issue swagger-api#6841, Map for accessing additionalProperties is generated. (swagger-api#6886) add tsloughter as owner erlang WIP: initial commit for Erlang client generator (swagger-api#6502) add back php client test Switch Travis image from MacOS to Linux (swagger-api#6937) add link to ebook [Scala] Default case class Option types to None for non-required fields (swagger-api#6790) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
PR created on @wing328 suggestion on #2305
This changes the file deserialization function to open the destination file in byte mode "wb" instead of text mode "w".
Using "w" mode can corrupt binary file because it replaces the bytes that represents new lines in text to make it platform specific.
See https://docs.python.org/2/tutorial/inputoutput.html
and https://docs.python.org/3/tutorial/inputoutput.html
Being a generic file deserialization that needs to handle both formats I guess it's more appropriate to leave the file exactly as it is.
Notes:
My changes were limited to what is described above, the rest of the changes were generated when running security/python-petstore.sh. Made 2 separate commits to make it easier to revert if the auto generate-part of security/python-petstore.sh is not correct or it has to be reverted.
@taxpon @frol @mbohlool @cbornet @kenjones-cisco