Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config property "enumPropertyNaming" to TypeScript codegens. #9176

Conversation

src-cfl
Copy link
Contributor

@src-cfl src-cfl commented Feb 15, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
    • N/A; this does not change the output for the configuration settings those samples use.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    • @ mentioning -> @CodeNinjai (JS member because there is no TS one)

Description of the PR

The new config property "enumPropertyNaming" allows overriding
how enum member names are capitalised or
snake_cased in generated code. It works very similarly to the Kotlin
generator's property of the same name.

The config property, when set to "original", will work round / fix #8494.

It allows overriding how enum member names are capitalised or
snake_cased in generated code.  It works very similarly to the Kotlin
generator property of the same name.
@src-cfl
Copy link
Contributor Author

src-cfl commented Feb 15, 2019

Do correct me if I have done the "Petstore" or "copy technical committee" steps incorrectly.

@tohyongcheng
Copy link

tohyongcheng commented Dec 16, 2019

Hi, can we have this looked at? @HugoMario

@duncan-ftw
Copy link

would be great to have this fix

Copy link

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamdes
Copy link

Hello @frantuma and @HugoMario
Would anyone like to review this pull-request ?
Cheers

@w-javed
Copy link

w-javed commented Aug 26, 2021

Please update the branch and merge it. LGTM

@HugoMario HugoMario self-assigned this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Typescript] Generated enum doesn't have underscores
7 participants