Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Option to skip client validations #9719

Closed
wants to merge 16 commits into from
Closed

[Python] Option to skip client validations #9719

wants to merge 16 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 14, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

@HugoMario
Copy link
Contributor

Thanks for this PR @slash-arun

can you please fix failing tests, such as:

Traceback (most recent call last):
  File "/home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/python/tests/test_enum_arrays.py", line 157, in test_equals
    self.assertEqual(fish1, fish2)
AssertionError: {'array_enum': ['fish'], 'just_symbol': '$'} != {'array_enum': ['fish'], 'just_symbol': '$'}

in order to merge them?

@ghost
Copy link
Author

ghost commented Oct 3, 2019

@HugoMario Sorry for leaving this PR hanging, I was caught up with something else. I will fix these asap

@ghost
Copy link
Author

ghost commented Oct 3, 2019

@HugoMario @kenjones-cisco @frantuma This PR is ready for review. Please take a look.

@HugoMario
Copy link
Contributor

thanks a lot @slash-arun, this LGTM but would like also someone else review

@ghost
Copy link
Author

ghost commented Oct 4, 2019

Sure @HugoMario , let me know if I should CC anyone else in particular. I already cc'd kenjones as per the document.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HugoMario
Copy link
Contributor

please build

@HugoMario
Copy link
Contributor

it seems the source repo was removed, i'm going to migrate changes to another PR in order to merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant