perf(resolver): utilize cache for OpenAPI 3.1 normalization (#3009)

Refs swagger-api/swagger-ui#8606
swagger-api · Jun 16, 2023 · 67bb618 · 67bb618
1 parent c7ccc36
commit 67bb618
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 39 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -114,10 +114,10 @@
   },
   "dependencies": {
     "@babel/runtime-corejs3": "^7.20.13",
-    "@swagger-api/apidom-core": ">=0.70.0 <1.0.0",
-    "@swagger-api/apidom-json-pointer": ">=0.70.0 <1.0.0",
-    "@swagger-api/apidom-ns-openapi-3-1": ">=0.70.0 <1.0.0",
-    "@swagger-api/apidom-reference": ">=0.70.0 <1.0.0",
+    "@swagger-api/apidom-core": ">=0.70.1 <1.0.0",
+    "@swagger-api/apidom-json-pointer": ">=0.70.1 <1.0.0",
+    "@swagger-api/apidom-ns-openapi-3-1": ">=0.70.2 <1.0.0",
+    "@swagger-api/apidom-reference": ">=0.70.2 <1.0.0",
     "cookie": "~0.5.0",
     "cross-fetch": "^3.1.5",
     "deepmerge": "~4.3.0",

diff --git a/src/resolver/strategies/openapi-3-1-apidom/normalize.js b/src/resolver/strategies/openapi-3-1-apidom/normalize.js
@@ -47,12 +47,17 @@ const normalize = (element) => {
  */
 export const pojoAdapter = (normalizeFn) => (spec) => {
   if (spec?.$$normalized) return spec;
+  if (pojoAdapter.cache.has(spec)) return spec;
 
   const openApiElement = OpenApi3_1Element.refract(spec);
   const normalized = normalizeFn(openApiElement);
+  const value = toValue(normalized);
 
-  return toValue(normalized);
+  pojoAdapter.cache.set(spec, value);
+
+  return value;
 };
+pojoAdapter.cache = new WeakMap();
 
 export default normalize;
 /* eslint-enable camelcase */