Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when the same component used in two different places in two different apis then parser fails #1627

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

when the same component used in two different places in two different apis then parser fails #1627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbff739
when the same component used in two different places in two different…
ptrsd Nov 17, 2021
9011ead
Merge branch 'master' into test-cases-for-ClassCastException-when-res…
gracekarina Feb 10, 2022
7cbf895
Merge branch 'master' into test-cases-for-ClassCastException-when-res…
gracekarina Feb 10, 2022
4606548
Merge branch 'master' into test-cases-for-ClassCastException-when-res…
gracekarina Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIV3ParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,52 @@ public void testIssueSameRefsDifferentModelValid() {
assertEquals(openAPI.getMessages().size(), 0);
}

@Test
public void testSameComponentInRequestAndResponseHeaders() throws IOException {
String pathFile = FileUtils.readFileToString(new File("src/test/resources/same-header-different-place-domain.yaml"), "UTF-8");
WireMock.stubFor(get(urlPathMatching("/issue-domain"))
.willReturn(aResponse()
.withStatus(HttpURLConnection.HTTP_OK)
.withHeader("Content-type", "application/json")
.withBody(pathFile
.getBytes(StandardCharsets.UTF_8))));

pathFile = FileUtils.readFileToString(new File("src/test/resources/same-header-different-place.yaml"), "UTF-8");
pathFile = pathFile.replace("${dynamicPort}", String.valueOf(this.serverPort));

OpenAPIV3Parser parser = new OpenAPIV3Parser();
ParseOptions options = new ParseOptions();
options.setResolve(true);
options.setResolveFully(true);
final SwaggerParseResult openAPI = parser.readContents(pathFile, null, options);
Yaml.prettyPrint(openAPI);

assertEquals(openAPI.getMessages().size(), 0);
}

@Test
public void testSameComponentInRequestAndResponseHeadersValid() throws IOException {
String pathFile = FileUtils.readFileToString(new File("src/test/resources/same-header-different-place-domain.yaml"), "UTF-8");
WireMock.stubFor(get(urlPathMatching("/issue-domain"))
.willReturn(aResponse()
.withStatus(HttpURLConnection.HTTP_OK)
.withHeader("Content-type", "application/json")
.withBody(pathFile
.getBytes(StandardCharsets.UTF_8))));

pathFile = FileUtils.readFileToString(new File("src/test/resources/same-header-different-place-valid.yaml"), "UTF-8");
pathFile = pathFile.replace("${dynamicPort}", String.valueOf(this.serverPort));

OpenAPIV3Parser parser = new OpenAPIV3Parser();
ParseOptions options = new ParseOptions();
options.setResolve(true);
options.setResolveFully(true);
final SwaggerParseResult openAPI = parser.readContents(pathFile, null, options);
Yaml.prettyPrint(openAPI);

assertEquals(openAPI.getMessages().size(), 0);
}

@Test
public void testIssue1398() {
ParseOptions options = new ParseOptions();
Expand Down
15 changes: 15 additions & 0 deletions modules/swagger-parser-v3/src/test/resources/same-header-different-place-domain.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
openapi: 3.0.0

components:
parameters:
testHeader:
name: testHeader
in: header
schema:
type: string

anotherHeader:
name: testHeader
in: header
schema:
type: string
25 changes: 25 additions & 0 deletions modules/swagger-parser-v3/src/test/resources/same-header-different-place-valid.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
openapi: 3.0.0
info:
version: "1.0.0"
title: Simple Inventory API
paths:
/api:
get:
parameters:
- $ref: 'http://localhost:${dynamicPort}/issue-domain/#/components/parameters/testHeader'
responses:
'200':
description: yet another success
headers:
testHeader:
$ref: 'http://localhost:${dynamicPort}/issue-domain/#/components/parameters/anotherHeader'
/api2:
get:
parameters:
- $ref: 'http://localhost:${dynamicPort}/issue-domain/#/components/parameters/testHeader'
responses:
'200':
description: yet another success
headers:
testHeader:
$ref: 'http://localhost:${dynamicPort}/issue-domain/#/components/parameters/testHeader'
25 changes: 25 additions & 0 deletions modules/swagger-parser-v3/src/test/resources/same-header-different-place.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
openapi: 3.0.0
info:
version: "1.0.0"
title: Simple Inventory API
paths:
/api:
get:
parameters:
- $ref: 'http://localhost:${dynamicPort}/issue-domain/#/components/parameters/testHeader'
responses:
'200':
description: yet another success
headers:
testHeader:
$ref: 'http://localhost:${dynamicPort}/issue-domain/#/components/parameters/testHeader'
/api2:
get:
parameters:
- $ref: 'http://localhost:${dynamicPort}/issue-domain/#/components/parameters/testHeader'
responses:
'200':
description: yet another success
headers:
testHeader:
$ref: 'http://localhost:${dynamicPort}/issue-domain/#/components/parameters/testHeader'
Loading