Skip to content
This repository has been archived by the owner on Sep 14, 2022. It is now read-only.

Handle route delegation properly #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

larochef
Copy link

When a set of routes is delegated to another router, there is a missing "/" between the prefix of the delegated route and the last part of the route.

For instance:

->       /endpoint        myEndpoint.router.Routes

and in the myEndpoint.router.routes:

GET    /my/endpoint     ....

would end up with url /endpointmy/endpoint insead of /endpoint/my/endpoint

@pjfanning
Copy link
Contributor

@larochef could you add some test cases?

@larochef
Copy link
Author

@pjfanning i'll have a look at how the delegation can be done in tests

@larochef larochef force-pushed the subroutes branch 2 times, most recently from e2082f2 to 0787941 Compare February 14, 2017 22:43
@larochef
Copy link
Author

@pjfanning I've added some tests, they helped me see some forgotten cases.

@larochef larochef force-pushed the subroutes branch 4 times, most recently from 1991896 to a664229 Compare February 15, 2017 10:01
@larochef
Copy link
Author

@pjfanning did you get a chance to have a look at it ?

@pjfanning
Copy link
Contributor

@larochef your change looks ok to me but you'll need a Member to review and merge

@JFCote
Copy link

JFCote commented Mar 8, 2017

I have the same problem and would like this fix. Is it going to be merged soon and released to maven ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants