This repository has been archived by the owner on Oct 30, 2019. It is now read-only.
JSR-356 Client - Add Support for Async Calls #51
Merged
+258
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added additional methods to return Future<Response> or Future<T> to allow for asynchronous calling when using the JSR-356 client. The user can now choose which is best suited for their use case -Tests were added for each of the new methods -Also added a test logback.xml to reduce a tremendous amount of debug log spam from the embedded tomcat container when running the tests
|
@elakito Finally had some time to work on this :-) Async support is all good now - sorry for the delay. See the new interface methods and tests. Let me know if you have any feedback. |
|
@starlightknight thanks and sorry for my delay in responding. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added additional methods to return Future or Future
to allow for asynchronous calling when using the JSR-356 client.
The user can now choose which is best suited for their use case
-Tests were added for each of the new methods
-Also added a test logback.xml to reduce a tremendous amount of
debug log spam from the embedded tomcat container when running
the tests