Skip to content

Commit

Permalink
housekeeping: @kyleshockey/js-yaml -> js-yaml (via #5511)
Browse files Browse the repository at this point in the history
* `@kyleshockey/js-yaml` -> `js-yaml`

* externalize `esprima`
  • Loading branch information
shockey authored Jul 31, 2019
1 parent 97260cf commit 2af696d
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 12 deletions.
20 changes: 14 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
"dependencies": {
"@babel/runtime-corejs2": "^7.5.5",
"@braintree/sanitize-url": "^2.0.2",
"@kyleshockey/js-yaml": "^1.0.1",
"@kyleshockey/object-assign-deep": "^0.4.2",
"@kyleshockey/xml": "^1.0.2",
"base64-js": "^1.2.0",
Expand All @@ -61,6 +60,7 @@
"ieee754": "^1.1.8",
"immutable": "^3.x.x",
"js-file-download": "^0.4.1",
"js-yaml": "^3.13.1",
"lodash": "^4.17.14",
"memoizee": "^0.4.12",
"prop-types": "^15.5.10",
Expand Down
2 changes: 1 addition & 1 deletion src/core/plugins/configs/helpers.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import YAML from "@kyleshockey/js-yaml"
import YAML from "js-yaml"

export const parseYamlConfig = (yaml, system) => {
try {
Expand Down
2 changes: 1 addition & 1 deletion src/core/plugins/spec/actions.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import YAML from "@kyleshockey/js-yaml"
import YAML from "js-yaml"
import { Map } from "immutable"
import parseUrl from "url-parse"
import serializeError from "serialize-error"
Expand Down
4 changes: 1 addition & 3 deletions webpack/_config-builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export default function buildConfig(
? {
// json-react-schema/deeper depends on buffertools, which fails.
buffertools: true,
esprima: true,
}
: (context, request, cb) => {
// webpack injects some stuff into the resulting file,
Expand All @@ -114,9 +115,6 @@ export default function buildConfig(
resolve: {
modules: [path.join(projectBasePath, "./src"), "node_modules"],
extensions: [".web.js", ".js", ".jsx", ".json", ".less"],
alias: {
"js-yaml": "@kyleshockey/js-yaml", // TODO: fix??
},
},

// If we're mangling, size is a concern -- so use trace-only sourcemaps
Expand Down

0 comments on commit 2af696d

Please sign in to comment.