improvement: do not require basic password in UI (#5812)

* Fix basic-auth.jsx: do not require password in UI password is not PropTypes.string.isRequired, but the markup wrongly makes it mandatory * Do not require password input in http-auth.jsx This is used by the Authorize modal. Not sure when the similar code from basic-auth.jsx is used. Co-authored-by: kyle shockey <kyle.shockey1@gmail.com>
swagger-api · Mar 22, 2020 · 95e72e7 · 95e72e7
1 parent 7178916
commit 95e72e7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/core/components/auth/basic-auth.jsx b/src/core/components/auth/basic-auth.jsx
@@ -73,8 +73,7 @@ export default class BasicAuth extends React.Component {
           <label>Password:</label>
             {
               username ? <code> ****** </code>
-                       : <Col><Input required="required"
-                                     autoComplete="new-password"
+                       : <Col><Input autoComplete="new-password"
                                      name="password"
                                      type="password"
                                      onChange={ this.onChange }/></Col>

diff --git a/src/core/plugins/oas3/components/http-auth.jsx b/src/core/plugins/oas3/components/http-auth.jsx
@@ -81,8 +81,7 @@ export default class HttpAuth extends React.Component {
           <label>Password:</label>
             {
               username ? <code> ****** </code>
-                       : <Col><Input required="required"
-                                     autoComplete="new-password"
+                       : <Col><Input autoComplete="new-password"
                                      name="password"
                                      type="password"
                                      onChange={ this.onChange }/></Col>