fix(utils): fix validation for required values without specified type

Refs #8007
swagger-api · Apr 22, 2024 · ca9f05a · ca9f05a
1 parent cf7b769
commit ca9f05a
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/src/core/utils/index.js b/src/core/utils/index.js
@@ -439,13 +439,26 @@ function validateValueBySchema(value, schema, requiredByParam, bypassRequiredChe
 
   const isValidNullable = nullable && value === null
 
+  // required value is not provided and there's no type defined in the schema
+  const requiredNotProvided =
+    schemaRequiresValue
+    && !hasValue
+    && !isValidNullable
+    && !bypassRequiredCheck
+    && !type
+
+  if (requiredNotProvided) {
+    errors.push("Required field is not provided")
+    return errors
+  }
+
   // will not be included in the request or [schema / value] does not [allow / require] further analysis.
   const noFurtherValidationNeeded =
     isValidNullable
     || !type
     || !requiresFurtherValidation
 
-  if(noFurtherValidationNeeded) {
+  if (noFurtherValidationNeeded) {
     return []
   }
 

diff --git a/test/unit/core/utils.js b/test/unit/core/utils.js
@@ -1037,6 +1037,22 @@ describe("utils", () => {
       value = 10
       assertValidateParam(param, value, [])
     })
+
+    it("validates required parameters without schema", () => {
+      // valid value
+      param = {
+        required: true
+      }
+      value = 123
+      assertValidateParam(param, value, [])
+
+      // missing value
+      param = {
+        required: true
+      }
+      value = undefined
+      assertValidateParam(param, value, ["Required field is not provided"])
+    })
   })
 
   describe("fromJSOrdered", () => {