Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Once you expand a data element of a schema, there is no way to collapse it again. #9595

Closed
ghost opened this issue Feb 14, 2024 · 4 comments · Fixed by #9639 · May be fixed by codingfragments/tvh-guide#134
Closed

Comments

@ghost
Copy link

ghost commented Feb 14, 2024

Q&A (please complete the following information)

  • OS: [e.g. macOS] Windows 10
  • Browser: [e.g. chrome, safari] Chrome
  • Version: [e.g. 22] 121
  • Method of installation: [e.g. npm, dist assets] npm
  • Swagger-UI version: [e.g. 3.10.0] Swagger UI React 5.11.3
  • Swagger/OpenAPI version: [e.g. Swagger 2.0, OpenAPI 3.0] OpenAPI 3.0

Content & configuration

Basic/ default

Describe the bug you're encountering

Once you expand a data element of a schema, there is no way to collapse it again.
It looks like collapsed data elements have a "td" with buttons containing class "model-box-control and span with classes "model-toggle collapsed" which are NOT included for the elements that are already expanded.

To reproduce...

Expand Schema, expand an input or output schema, expand a data element. Once expanded, there is no way to contract it again.

Expected behavior

Once expanded, it should be collapsible

Screenshots

Note for the expanded elements, there is no caret to collapse it again.
image

Additional context or thoughts

@rajat-gith
Copy link

I am really interested in working on this issue. Can you assign it to continue with this issue.

@rajat-gith
Copy link

@cjfreedman I would be thankful if you could assign this issue to me.

@ghost
Copy link
Author

ghost commented Feb 20, 2024

@rajat-gith I don't have authority to assign it to you. I suggest you just fix it and then submit a pull request.

dakkkshh added a commit to dakkkshh/swagger-ui that referenced this issue Feb 24, 2024
@glowcloud
Copy link
Contributor

Addressed in #9639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants