Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Swagger UI configuration logic into config #9806

Closed
glowcloud opened this issue Apr 11, 2024 · 1 comment
Closed

Consolidate Swagger UI configuration logic into config #9806

glowcloud opened this issue Apr 11, 2024 · 1 comment
Assignees
@char0n @glowcloud
Labels
type: enhancement version: 5.x

Comments

@glowcloud
Copy link
Contributor

Currently the logic for getting configuration options is contained inside: https://github.com/swagger-api/swagger-ui/blob/master/src/core/index.js

We should move it to a separate config module and refactor it to make the code more understandable and maintanable.
@glowcloud glowcloud self-assigned this Apr 12, 2024
glowcloud added a commit that referenced this issue Apr 12, 2024
@glowcloud
refactor: consolidate configuration code into config
5f977bf 
Refs #9806
@glowcloud glowcloud mentioned this issue Apr 12, 2024
Merged
char0n added a commit that referenced this issue Apr 15, 2024
@glowcloud @char0n
refactor: consolidate all config related code into config module (#9811)
68eb346 
Refs #9806

Co-authored-by: Vladimír Gorej <vladimir.gorej@gmail.com>
@glowcloud
Copy link
Contributor Author

Addressed in 68eb346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

@glowcloud glowcloud

Labels
type: enhancement version: 5.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@char0n @glowcloud