Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated color definition in _color.scss #4973

Closed

Conversation

chongpang
Copy link

@chongpang chongpang commented Oct 26, 2018

Description

Following variables defined in _variables.scss

 $_color-post: #49cc90 !default; 
 $_color-get: #61affe !default; 
 $_color-put: #fca130 !default; 
 $_color-delete: #f93e3e !default; 
 $_color-head: #9012fe !default; 
 $_color-patch: #50e3c2 !default; 
 $_color-disabled: #ebebeb !default; 
 $_color-options: #0d5aa7 !default; 

are redefined in _colors.scss

Motivation and Context

Fixes #4967

How Has This Been Tested?

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@shockey shockey mentioned this pull request May 3, 2019
17 tasks
@shockey
Copy link
Contributor

shockey commented Mar 8, 2020

closing as we've since resolved this — thanks @chongpang!

@shockey shockey closed this Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colors defined twice with no default options
2 participants