Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic-auth.jsx: do not require password in UI #5812

Merged
merged 3 commits into from
Mar 22, 2020
Merged

Fix basic-auth.jsx: do not require password in UI #5812

merged 3 commits into from
Mar 22, 2020

Commits on Jan 29, 2020

  1. Fix basic-auth.jsx: do not require password in UI 

    password is not PropTypes.string.isRequired, but the markup wrongly makes it mandatory
    @Simran-B
    Simran-B authored Jan 29, 2020
    Configuration menu
    Copy the full SHA
    ee1ab88 View commit details
    Browse the repository at this point in the history

  2. Do not require password input in http-auth.jsx 

    This is used by the Authorize modal. Not sure when the similar code from basic-auth.jsx is used.
    @Simran-B
    Simran-B authored Jan 29, 2020
    Configuration menu
    Copy the full SHA
    3e59277 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2020

  1. Merge branch 'master' into patch-1

    @shockey
    shockey authored Mar 22, 2020
    Configuration menu
    Copy the full SHA
    93d9390 View commit details
    Browse the repository at this point in the history