feat(build): expose true ESM bundle as primary artifact #7937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char0n
commented
Mar 24, 2022
|
@char0n Just a quick comment that this PR will possibly break downstream users of SwaggerUI. When SwaggerUI moved to Webpack@5, there was consensus to not break existing npm library outputs. Considering that we do want to move SwaggerEditor to Webpack@5 as well, if this change is needed to enable SwaggerEditor forward migration, we probably should consider bumping the major version of both SwaggerUI and SwaggerEditor to v5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #7907