Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add OpenAPIVersion component #9167

Merged
merged 1 commit into from
Aug 31, 2023
Merged

feat: add OpenAPIVersion component #9167

merged 1 commit into from
Aug 31, 2023

Conversation

kowalczyk-krzysztof
Copy link
Contributor

Refs SWG-8477

@kowalczyk-krzysztof kowalczyk-krzysztof force-pushed the feat/oas2-badge branch 7 times, most recently from cfa49c6 to f5a1cda Compare August 25, 2023 12:35
char0n added a commit that referenced this pull request Aug 25, 2023
@char0n
feat: display OpenAPI spec version
d82ce0d 
Refs #9167
@char0n char0n mentioned this pull request Aug 25, 2023
Closed
@char0n char0n self-assigned this Aug 25, 2023
@char0n
Copy link
Member

char0n commented Aug 25, 2023

Hi @kowalczyk-krzysztof,

Looks good and gets the job done. I was thinking about a possible simplification in #9170

Now that we know we need to display OpenAPI version always, let's introduce a new OpenAPIVersion component instead of hacking VersionStamp which was intended originally just to display Info Object.version field. This way we'll achieve separation of concerns and allow OpenAPIVersion to be overriden by plugins, when somebody decides he/she wants to display the version in different way.

@kowalczyk-krzysztof
Copy link
Contributor Author

I agree, a separate component seems better 👍🏻
I'll change my implementation.

@kowalczyk-krzysztof kowalczyk-krzysztof force-pushed the feat/oas2-badge branch 5 times, most recently from e05a358 to f062324 Compare August 28, 2023 07:00
@kowalczyk-krzysztof kowalczyk-krzysztof changed the title feat: add oas 2.0 badge feat: add OpenAPIVersion component Aug 28, 2023
@kowalczyk-krzysztof
Copy link
Contributor Author

I changed my implementation to introduce OpenAPIVersion component.

@char0n
Copy link
Member

char0n commented Aug 31, 2023

Closing #9170 as it's been incorporated in this PR.

char0n
char0n approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! THanks!

@char0n char0n merged commit 4b48e36 into master Aug 31, 2023
6 checks passed
@kowalczyk-krzysztof kowalczyk-krzysztof deleted the feat/oas2-badge branch August 31, 2023 11:10
@char0n char0n mentioned this pull request Sep 28, 2023
Merged
char0n pushed a commit that referenced this pull request Sep 28, 2023
@tekyu
feat: add wrapper for version labels (#9264)
1addcfe 
Refs #9167
@tekyu tekyu mentioned this pull request Sep 29, 2023
Merged
char0n pushed a commit that referenced this pull request Sep 29, 2023
@tekyu
feat: add wrapper for OpenAPI 3.1.0 version label (#9267)
aa9cf56 
Refs #9167 
Refs #9264
@Azquelt Azquelt mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

Assignees

@char0n char0n

Labels
type: enhancement version: 5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kowalczyk-krzysztof @char0n