Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: justify-content property #9421

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Dec 6, 2023

Description

fix a css property according to specs, no functional changes

Motivation and Context

How Has This Been Tested?

tested with and without servers (firefox and chrome)

Screenshots

obrazek

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@glowcloud glowcloud self-assigned this Feb 14, 2024
@glowcloud
Copy link
Contributor

Thanks for the suggested changes!

Could I ask you to confirm if this issue still exists in the current versions of the browsers? I could not replicate the button moving to the left when loading a specification without schemes.

@ahorek
Copy link
Contributor Author

ahorek commented Feb 14, 2024

@glowcloud thanks for looking into it.

I've double-checked and can't simulate the issue anymore, even with the old bundle. I'm on Firefox 122.0.1 now, so most likely they've fixed the issue on their side.

anyway, justify-content: none; should still be removed because it's invalid. Should I rebase the PR?

Copy link
Contributor

@glowcloud glowcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the confirmation!
Please take a look at my comment.

src/style/_layout.scss Show resolved Hide resolved
@ahorek ahorek force-pushed the fix_right_auth_button branch from 0baafe0 to df8c8e4 Compare February 15, 2024 11:15
@ahorek ahorek changed the title fix: ensure the authorize btn stays on the right (firefox) fix: justify-content property Feb 15, 2024
@ahorek ahorek force-pushed the fix_right_auth_button branch from f2dc299 to c297656 Compare February 15, 2024 11:21
Copy link
Contributor

@glowcloud glowcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

@glowcloud glowcloud merged commit 2a2956f into swagger-api:master Feb 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants