-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: justify-content property #9421
Conversation
Thanks for the suggested changes! Could I ask you to confirm if this issue still exists in the current versions of the browsers? I could not replicate the button moving to the left when loading a specification without schemes. |
@glowcloud thanks for looking into it. I've double-checked and can't simulate the issue anymore, even with the old bundle. I'm on Firefox 122.0.1 now, so most likely they've fixed the issue on their side. anyway, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the confirmation!
Please take a look at my comment.
0baafe0
to
df8c8e4
Compare
f2dc299
to
c297656
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, LGTM!
Description
fix a css property according to specs, no functional changes
Motivation and Context
justify-content: none;
is an invalid css, see https://developer.mozilla.org/en-US/docs/Web/CSS/justify-contentHow Has This Been Tested?
tested with and without servers (firefox and chrome)
Screenshots
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests