Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spec): render response body for non-200 responses #9555

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

glowcloud
Copy link
Contributor

@glowcloud glowcloud commented Feb 7, 2024

Refs #9556

@glowcloud glowcloud self-assigned this Feb 7, 2024
@glowcloud glowcloud requested a review from char0n February 7, 2024 10:24
@char0n
Copy link
Member

char0n commented Feb 7, 2024

I'm wondering why we use serializeError when creating payloads.
Flux Standard Action doesn't have any limitation over what can be attached to the action payload. Only reducers when and if reducing errors, should possibly use serializeError.
I don't see any reason why we should serialize the error, if you drop the serialization, the issue will be resolved, without any other change, right?

Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We can further simplify the change by not using serializeError for flux action payloads.

Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@char0n char0n merged commit a88bed5 into master Feb 7, 2024
6 checks passed
@char0n char0n deleted the fix-response-body-render branch February 14, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants