Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: consolidate all JSON Schema 5 rendering code into json-schema-5 plugin #9797

Closed
wants to merge 5 commits into from
Closed

refactor: consolidate all JSON Schema 5 rendering code into json-schema-5 plugin #9797

wants to merge 5 commits into from

Conversation

char0n
Copy link
Member

@char0n char0n commented Apr 10, 2024

No description provided.

@char0n char0n self-assigned this Apr 10, 2024
@char0n char0n requested a review from glowcloud April 10, 2024 08:58
glowcloud
glowcloud approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@glowcloud glowcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I was wondering about the naming of this as 'json-schema-5' because of OpenAPI 2.0 as I think it uses these components as well, but this also seems to be the case with json-schema-5-samples, so I think it's fine

@char0n
Copy link
Member Author

char0n commented Apr 10, 2024

I was wondering about the naming of this as 'json-schema-5' because of OpenAPI 2.0 as I think it uses these components as well, but this also seems to be the case with json-schema-5-samples, so I think it's fine

Both OpenAPI 2.0 and OpenAPI 3.0.x are using JSON Schema Draft 5, they just support different sets of keywords and change semantics to others, but they use the same spec.

@char0n
Copy link
Member Author

char0n commented Apr 10, 2024

Superseded by #9798

@char0n char0n closed this Apr 10, 2024
@char0n char0n deleted the char0n/json-schema-5 branch April 19, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glowcloud glowcloud glowcloud approved these changes

Assignees

@char0n char0n

Labels
type: enhancement version: 5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@char0n @glowcloud