Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swagger-ui-react): rewrite into SSR compatible function component #9855

Merged
merged 8 commits into from
Apr 22, 2024

Conversation

char0n
Copy link
Member

@char0n char0n commented Apr 20, 2024

Refs #9243

Description

This is a rewrite of swagger-ui-react from class component into function component. Class components are starting to be completely unsupported by the modern browsers.

Motivation and Context

#9243

How Has This Been Tested?

Using https://github.com/char0n/swagger-ui-nextjs

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Resources:

Copy link
Contributor

@glowcloud glowcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, not seeing anything missing.

I also ran projects with React and Next.js and had no errors. There are only warnings that I saw there before: Failed to parse source map for some modules in React and UNSAFE_componentWillReceiveProps in both, but the second one is just for the future rewrite of class components.

@char0n
Copy link
Member Author

char0n commented Apr 22, 2024

Verified that babel tranpisaltion doesn't remove "use client" directive.

@char0n char0n merged commit 351191b into master Apr 22, 2024
8 checks passed
@char0n char0n deleted the char0n/9243 branch May 13, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants