-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swagger-ui-react): rewrite into SSR compatible function component #9855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, not seeing anything missing.
I also ran projects with React and Next.js and had no errors. There are only warnings that I saw there before: Failed to parse source map
for some modules in React and UNSAFE_componentWillReceiveProps
in both, but the second one is just for the future rewrite of class components.
Verified that babel tranpisaltion doesn't remove |
Refs #9243
Description
This is a rewrite of
swagger-ui-react
from class component into function component. Class components are starting to be completely unsupported by the modern browsers.Motivation and Context
#9243
How Has This Been Tested?
Using https://github.com/char0n/swagger-ui-nextjs
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests
Resources: