Disable autocompletion for authorization secrets #9935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request set
autoComplete=off
to the inputs below so as not to expose the bearer's API key and token by autocompletion when typed.swagger-ui/src/core/components/auth/api-key-auth.jsx
Lines 73 to 78 in 1367a8f
swagger-ui/src/core/plugins/oas3/components/auth/http-auth.jsx
Lines 132 to 138 in 1367a8f
Motivation and Context
close #9921
How Has This Been Tested?
I opened my browser with
localhost:3200
. I clicked on authorize, start typing a secret and closed the modal window.I reopened the modal window, logged out and started typing a secret again. Autocomplete did not appear.
Screenshots (if appropriate):
Screencast.from.2024-05-13.20-47-19.webm
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests