-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pre-routing middlewares by using chi's management #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines Of Code
|
Go API Changes# summary Inferred base version: v0.2.22 Suggested version: v0.2.23 |
Unit Test Coveragetotal: (statements) 82.7% Coverage diff with base branch22c22
< github.com/swaggest/rest/chirouter/wrapper.go prepareHandler 100.0%
---
> github.com/swaggest/rest/chirouter/wrapper.go captureHandler 100.0%
76a77
> github.com/swaggest/rest/nethttp/wrap.go String 0.0%
112,113c113,114
< github.com/swaggest/rest/request/middleware.go DecoderMiddleware 90.9%
< github.com/swaggest/rest/request/middleware.go ValidatorMiddleware 85.7%
---
> github.com/swaggest/rest/request/middleware.go DecoderMiddleware 100.0%
> github.com/swaggest/rest/request/middleware.go ValidatorMiddleware 100.0%
160c161
< total: (statements) 82.8%
---
> total: (statements) 82.7% |
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 76.56% 76.72% +0.16%
==========================================
Files 27 27
Lines 1314 1319 +5
==========================================
+ Hits 1006 1012 +6
- Misses 193 194 +1
+ Partials 115 113 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Benchmark ResultBenchmark diff with base branch
Benchmark result
|
Examples Benchmark ResultBenchmark diff with base branch
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62