-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure the default OAuth2 ClientID #209
Conversation
61c8233
to
948a7d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 93 98 +5
=========================================
+ Hits 93 98 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@joshstrohminger would you mind updating the README.md file regarding this feature? |
…ersistAuthorization option
Sorry I missed the readme update. Let me know if it's not to your liking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@joshstrohminger Thanks for your contribution. |
Describe the PR
Allow callers to configure the default ClientID for OAuth2. This just pre-populates the
client_id
form field in the Authorize dialog. Here is what it looks like using the following line config:Relation issue
None
Additional context
This is done by calling the
initOAuth
function with the configured value if one is provided.