fix: fix cli dependencies #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #603 +/- ##
==========================================
- Coverage 85.94% 85.82% -0.12%
==========================================
Files 7 7
Lines 1693 1693
==========================================
- Hits 1455 1453 -2
- Misses 149 150 +1
- Partials 89 90 +1
Continue to review full report at Codecov.
|
|
@swaggo/swaggo-core-team please help review it. |
|
I will jump to v1.6.5 if there are no problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used clone
swag/cliinstead ofurfave/clias not compatible with original v1 codes. Nowurfave/cliv2 has a different package name. so that we can still use v1.In the meantime, also drop go1.10 supporting for compatible with
urfave/cli.Also fix #598