Skip to content

Commit

Permalink
Some README tweaks, a forkArg param to ease visualvm connections for …
Browse files Browse the repository at this point in the history
…sampling.
  • Loading branch information
swaldman committed Mar 3, 2024
1 parent be7349b commit e0b5347
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
10 changes: 8 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@ Thank you for your interest in c3p0. I do hope that you find it useful!

### Building c3p0

For now (v0.10.0), c3p0 is built under a Java 11 VM, targetting JDK 7 classfiles for continued compatibility with legacy apps.
In order to remind me to switch to Java 11, the build will fail with an Exception if it detects an unexpected version.
You can comment this requirement out of `build.sc` if you like. It's the line that looks like

```scala
require( sys.props("java.runtime.version").startsWith("11"), s"Bad build JVM: ${sys.props("java.runtime.version")} -- We currently expect to build under Java 11. (We generate Java $JvmCompatVersion compatible source files.)" )
```

c3p0 relies on the excellent build tool [`mill`](https://mill-build.com/).

Install `mill`. Then, within this repository direcory, run
Expand All @@ -34,8 +42,6 @@ If you maintain a local ivy repository, You can customize `publishVersion` in [`
$ mill publishLocal
```

For now (v0.10.x), c3p0 is built under a Java 11 VM, targetting JDK 7 classfiles for continued compatibility with legacy apps.

To build the documentation

```plaintext
Expand Down
1 change: 1 addition & 0 deletions build.sc
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ object c3p0 extends RootModule with JavaModule with PublishModule {
//"-Xrunhprof:file=/tmp/java.hprof,doe=y,format=b" ::
//"-verbose:class"
//"-ea" ::
"-Djava.rmi.server.hostname=localhost" ::
s"""-Djava.util.logging.config.file=${millSourcePath / "conf-logging" / "logging.properties"}""" ::
Nil
}
Expand Down

0 comments on commit e0b5347

Please sign in to comment.