-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm target integration #96
Conversation
Hi, any updates about the merge? |
@N7ghtm4r3 CI pipeline is broken, can you please check and fix it |
Can you change the org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find https://cdn.jsdelivr.net/npm/ua-parser-js:.
Required by:
project :KDeviceInfo But that is required by the @OptIn(ExperimentalWasmDsl::class)
wasmJs {
binaries.executable()
browser {
webpackTask {
dependencies {
implementation(libs.x.cdn.jsdelivr.net.npm.ua.parser.js) //here the CI pipeline does not found the package
}
}
}
} |
Hi, is there any way to bypass that CI pipeline to merge the pull request? |
Yes, there is option, but if this code get merged then all the future CI pipeline start broke and at the end it will become blocker when we want to publish new lib version through CD. Can you please make the necessary changes so CI pipeline will start working. |
Hi, unfortunately that snippet Is mandatory to implement and import the |
@N7ghtm4r3 I've made the required changes, CI is working fine Allow me sometime will merge this PR Thanks for the contribution man 🚀 |
Thank you too! |
Hi, any updates about the merge? |
Thank you man! |
Integrated the
wasm
target integration based on theJS
ua-parser library.I have refactored the
DeviceInfoXExt.kt
adding also thedesktop
and thewasm
targets to execute the relatedOnPlatform
andonPlatform
branch