Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm target integration #96

Merged
merged 9 commits into from
Dec 5, 2024
Merged

Conversation

N7ghtm4r3
Copy link
Contributor

Integrated the wasm target integration based on the JS ua-parser library.
I have refactored the DeviceInfoXExt.kt adding also the desktop and the wasm targets to execute the related OnPlatform and onPlatform branch

@N7ghtm4r3
Copy link
Contributor Author

Hi, any updates about the merge?

@swapnil-musale
Copy link
Owner

@N7ghtm4r3 CI pipeline is broken, can you please check and fix it

@N7ghtm4r3
Copy link
Contributor Author

Can you change the CI pipeline? Because the issue was caused due this:

org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find https://cdn.jsdelivr.net/npm/ua-parser-js:.
Required by:
    project :KDeviceInfo

But that is required by the wasmJs target here:

 @OptIn(ExperimentalWasmDsl::class)
    wasmJs {
        binaries.executable()
        browser {
            webpackTask {
                dependencies {
                    implementation(libs.x.cdn.jsdelivr.net.npm.ua.parser.js) //here the CI pipeline does not found the package
                }
            }
        }
    }

@N7ghtm4r3
Copy link
Contributor Author

Hi, is there any way to bypass that CI pipeline to merge the pull request?

@swapnil-musale
Copy link
Owner

Hi, is there any way to bypass that CI pipeline to merge the pull request?

Yes, there is option, but if this code get merged then all the future CI pipeline start broke and at the end it will become blocker when we want to publish new lib version through CD.

Can you please make the necessary changes so CI pipeline will start working.

@N7ghtm4r3
Copy link
Contributor Author

Hi, unfortunately that snippet Is mandatory to implement and import the ua-parser-js library so must be stay at the moment and I cannot change it

@swapnil-musale
Copy link
Owner

@N7ghtm4r3 I've made the required changes, CI is working fine

Allow me sometime will merge this PR

Thanks for the contribution man 🚀

@N7ghtm4r3
Copy link
Contributor Author

Thank you too!

@N7ghtm4r3
Copy link
Contributor Author

Hi, any updates about the merge?

@swapnil-musale swapnil-musale merged commit fad0875 into swapnil-musale:master Dec 5, 2024
1 check passed
@N7ghtm4r3
Copy link
Contributor Author

Thank you man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants