Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Telegram Notifications #364

Merged
merged 9 commits into from
May 15, 2021
Merged

Adding Telegram Notifications #364

merged 9 commits into from
May 15, 2021

Conversation

swar
Copy link
Owner

@swar swar commented May 15, 2021

No description provided.

@swar swar merged commit 8b8a88b into development May 15, 2021
@swar swar deleted the telegram-notifications branch May 17, 2021 06:55
@swar swar mentioned this pull request May 20, 2021
@fiveangle
Copy link

This should be rolled back until it works. Telegram api requires the chat id or there's no way to route the alert.

@swar
Copy link
Owner Author

swar commented May 22, 2021

This should be rolled back until it works. Telegram api requires the chat id or there's no way to route the alert.

It's already in and doesn't hurt anyone using it right now. I'm not going to spend the time to make a new version to just remove it to add it back in on another release.

@fiveangle
Copy link

if it isn't messing anything up, i see your point. luckily there are fixes already submitted by others

@millstone98
Copy link

millstone98 commented May 29, 2021

@fiveangle where can I find the fixes? Do you know if we can get it running? I've inserted the telegram_token and set notify_telegram to true but it doesn't seem to work.

@fiveangle
Copy link

fiveangle commented Jun 1, 2021

#757 is supposed to fix, but it did not work for me. I have not had time to dig into it further (on vacation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants