Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor style is set to "none" #72

Closed
Mikle-Bond opened this issue Jul 29, 2023 · 4 comments
Closed

Cursor style is set to "none" #72

Mikle-Bond opened this issue Jul 29, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@Mikle-Bond
Copy link

I see that cursor is meant to change when hovering over plugin icon. But when there are no plugin updates, the cursor disappears. Is that an intended behavior? I personally see this as a bug, because cursor shouldn't disappear without explicit reason.

I believe this is where such behavior originates from. Can we change it to 'default' or is it meant to be 'none' for some other reason?

@swar8080
Copy link
Owner

Hi, thanks for reporting

The cursor was removed to make it clearer that nothing happens when clicking the icon if there's no updates. Someone was confused by the cursor in #7. I can't think of anything useful to display when there's no updates but let me know if you have suggestions about how to handle this

@Mikle-Bond
Copy link
Author

Ah, I see. But hiding cursor is still not the way, IMHO. Because now my cursor disappears right before i want to change the size of Obsidian's window)

Proposal: I think it would be better if a new modal window was added, with a big green circle with a confirmation tick, and something like "All plugins are up to date!". That'd fit as a solution to my confusion, and for our colleague from #7

Explicit is better than implicit.

Yes, I know there's a pop-up with this exact same purpose and text (even two of them on my machine, dunno why, see screenshot below), but a little feedback on click would improve UX slightly.

screenshot

@swar8080
Copy link
Owner

swar8080 commented Aug 10, 2023

that makes sense, a toast/notice icon seems like a good fit for that message

i'll get around to implementing this at some point but you're welcome to if interested

@swar8080 swar8080 added the good first issue Good for newcomers label Aug 10, 2023
@swar8080 swar8080 mentioned this issue Aug 12, 2023
swar8080 added a commit that referenced this issue Aug 12, 2023
* Clicking the plugin icon when no updates are available now shows a small message making it clearer that everything's up-to-date. The cursor no longer disappears when hovering over the plugin icon (Cursor style is set to "none" #72)

* Updates the description for the setting Minimum update count to show a plugin icon to mention that updates for this plugin are always shown (in-case there's a bug preventing you from seeing other updates) (#67)

* Clearer message when your IP address exceeds github's limit of 60 file downloads per hour when updating plugins. The number of minutes until the limit is reset is included in the message (Many plugins refuse update - while others did fine #73)

* Cleans-up some error logs in the developer console (Error when no internet connection  #68)

* Increases the max number of your installed plugins checked for updates from 350 to 400 (if this is still too low then let me know)
@swar8080
Copy link
Owner

Improved this in the latest release, thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants