Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better support for structure references #2164

Merged
merged 1 commit into from
Oct 12, 2024
Merged

better support for structure references #2164

merged 1 commit into from
Oct 12, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Oct 11, 2024 •
edited
Loading

  • Ensure that toplevel structure definitions can reference each other
  • Refactor acyclic graph validation
  • Revised the nested-structure.yaml test to exercise "backwards" structure references
  • Add a test that exercises recursive structure references
  • Add a bit more comments/documentation

Testing

./scripts/play.sh --scenario data/scenarios/Testing/_Validation/795-prerequisite-cycle.yaml

and

./scripts/play.sh --scenario data/scenarios/Testing/_Validation/2164-recursive-structure.yaml

@kostmo kostmo added the T-Testing Involves the testing suite - unit and integration tests, also benchmarks. label Oct 11, 2024
@kostmo kostmo force-pushed the testing/structure-references branch 2 times, most recently from e9d9dae to e60768f Compare October 11, 2024 05:47
@kostmo kostmo requested a review from byorgey October 11, 2024 05:54
@kostmo kostmo marked this pull request as ready for review October 11, 2024 05:54
@kostmo kostmo mentioned this pull request Oct 11, 2024
Merged
@kostmo kostmo force-pushed the testing/structure-references branch from e60768f to 36f6de4 Compare October 11, 2024 15:50
@kostmo kostmo requested a review from xsebek October 11, 2024 16:18
@kostmo kostmo force-pushed the testing/structure-references branch from 36f6de4 to 4cd3982 Compare October 11, 2024 16:27
byorgey
byorgey approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Oct 12, 2024
@mergify mergify bot merged commit b31b13d into main Oct 12, 2024
14 checks passed
@mergify mergify bot deleted the testing/structure-references branch October 12, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

@xsebek xsebek Awaiting requested review from xsebek

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. T-Testing Involves the testing suite - unit and integration tests, also benchmarks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey