Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow []= on ImmutableDict #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disallow []= on ImmutableDict #89

wants to merge 1 commit into from

Conversation

bfontaine
Copy link
Collaborator

The current behavior is confusing, see #88.

Fixes #88.

Copy link
Owner

@swaroopch swaroopch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bfontaine
Copy link
Collaborator Author

I’m waiting on #90 to fix the build.

@bfontaine
Copy link
Collaborator Author

Well I don’t think this build will ever run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImmutableDicts should throw errors on attempted mutation
2 participants