Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12/23 - changes to MUSLE C factor and some carbon updates #35

Merged
merged 10 commits into from
Dec 30, 2024

Conversation

tugraskan
Copy link
Collaborator

12/23 - changes to MUSLE C factor and some carbon updates

Jeff Arnold and others added 10 commits December 12, 2024 14:51
changes to MUSLE C factor and some carbon updates
cal_parmchg_read: Updated the assignment for the "swq" case from sp_ob to db_mx.

cbn_zhang2: Simplified sol_mass calculation.

ero_cfactor: Modified residue and ground cover factor calculations.

hyd_connect: Increased iord threshold to 5000 to resolve infinite loop timeout issue.

nut_orgnc2: Simplified total carbon calculation.

res_nutrient: Excluded soluble nutrients from removal.

soil_nutcarb_write: Removed redundant comment.

wet_initial:
Refactor wet_initial subroutine:

Removed duplicate reservoir_data_module import.
Added conditional_module import for improved logic control.
Added new counter variables and simplified the crosswalk with wetland data files and initialization of parameters.
Optimized checks for missing wetland data and variable assignments.
Removed redundant salt and constituent concentration setup.
Streamlined surface area and depth calculations for wetland on HRU.
wet_read:
Refactor wet_read subroutine:

Removed conditional_module.
Eliminated logic for initializing organic minerals, pesticides, pathogens, and salts.
Simplified wetland data reading loop.
@odav odav requested a review from fgeter December 30, 2024 16:39
Copy link
Collaborator

@fgeter fgeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look ok to me.

@odav odav merged commit b5c414e into swat-model:main Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants