Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDE's SNI implementation is noncompliant #1372

Closed
uberbrodt opened this issue Sep 26, 2017 · 31 comments · Fixed by #3249
Closed

KDE's SNI implementation is noncompliant #1372

uberbrodt opened this issue Sep 26, 2017 · 31 comments · Fixed by #3249

Comments

@uberbrodt
Copy link

Hi,
I understand that SNI support is enabled in 0.14, but I can't seem to get it to work. I've tried a couple of programs that I know have indicators (transmission-qt, kmix) and neither show up.

sway version (2017-08-09, branch "")

@uberbrodt
Copy link
Author

uberbrodt commented Sep 26, 2017

sway.log

@ddevault
Copy link
Contributor

Do those actually support SNI? Try konversation.

@uberbrodt
Copy link
Author

uberbrodt commented Sep 26, 2017 via email

@ddevault
Copy link
Contributor

09/25/17 22:05:21 - [main.c:52] [wlc] unable to lock lockfile /run/user/1000/wayland-0.lock, maybe another compositor is running

Are you running another compositor?

@uberbrodt
Copy link
Author

Hangon, that maybe a bad log. I started sway a couple of times inside another sway session while trying to get debug logging going.

sway.log

@ddevault
Copy link
Contributor

I'm not sure how the Fedora package works. Can you try building Sway from source and see if you can reproduce the issue? Post the cmake output as well.

@uberbrodt
Copy link
Author

uberbrodt commented Sep 26, 2017 via email

@nemanjan00
Copy link

Any progress?

@4e554c4c
Copy link
Contributor

There isn't enough information to reproduce, so no. However if you've experiencing the problem then maybe you could help out.

@nemanjan00
Copy link

Turns out tray is disabled by default in konversation on Arch... :)
Works for me

@uberbrodt
Copy link
Author

uberbrodt commented Oct 12, 2017 via email

@cjacker
Copy link

cjacker commented Oct 19, 2017

SNI support requires a session bus setup before starting sway, if launch sway from TTY, run 'dbus-launch sway', tray should work properly.

@4e554c4c
Copy link
Contributor

@gnidorah Please attatch a debug log of swaybar. This can be done by killing swaybar after starting sway, and running swaybar -d --bar_id bar-0 2> swaybar.log

@ghost
Copy link

ghost commented Oct 20, 2017

@4e554c4c Is this a culprit?

10/20/17 21:30:58 - [sni_watcher.c:153] RegisterStatusNotifierItem called with "/org/ayatana/NotificationItem/example_simple_client"

10/20/17 21:30:58 - [sni_watcher.c:157] This item is not valid, we cannot keep track of it.

@4e554c4c
Copy link
Contributor

Yeah, that's it. The problem is that the client is trying to register by object path, which is a "hidden feature" of KDE's SNI implimentation. It's not yet supported because it'd require some deviation from the SNI protocol to make, but it's planned for the future.

@4e554c4c
Copy link
Contributor

We follow the specification plus all the deviations from it that I could find in kde software, eg using org.kde.*, registering by unique name, etc. I'll try to add support for these too, it's just difficult to imagine all the different ways people could impliment the specification.

@4e554c4c
Copy link
Contributor

Ok, support is in the works. @gnidorah if you could link me to your example libappindicator client it'd help a lot.

@ghost
Copy link

ghost commented Oct 23, 2017

@4e554c4c Here it is https://askubuntu.com/questions/42211/how-to-create-unity-indicators/234204#234204 and here are build instructions on the top of file https://github.com/dorkbox/SystemTray/blob/master/test/example.c
It worked for me under i3 and plasma5. 'go-jump' icon should be in theme.

@ddevault ddevault changed the title How to enable systray in 0.14? KDE's SNI implementation is noncompliant Oct 23, 2017
@uberbrodt
Copy link
Author

Sorry for being so late to follow up...I was able to build and test the HEAD revision today and I can confirm that the Konversation icon shows up, however I'm unable to make it respond to actions with either right or left mouse button clicks.

@ghost
Copy link

ghost commented Oct 30, 2017

Here to note that KDE SNI works great for me, minor issue is that the right click menu shows in the top right corner, while the bar in my config is at bottom.

@4e554c4c
Copy link
Contributor

Nice catch, I'll fix that.

@4e554c4c
Copy link
Contributor

Should be fixed with #1431

@ghost
Copy link

ghost commented Nov 1, 2017

@4e554c4c Indeed it fixes, thank you!

@ghost
Copy link

ghost commented Nov 15, 2017

@4e554c4c Another little issue is when I click on ksni4 menu entry under i3, menu auto closes as I expect, but under sway it stay open until I click tray icon again.

@ghost
Copy link

ghost commented Nov 20, 2017

@4e554c4c Icon updating doesn't happen on external HDMI monitor but happens on internal eDP with default config. Is this a problem with tray or with something else? Thanks

@4e554c4c
Copy link
Contributor

Not sure, it's probably us though. I'm working on the menu right now but I'll check that out.

@r3k2
Copy link

r3k2 commented Dec 22, 2017

Hello I tested this with konversation and icon shows but when I click on it no menu, also Idk how to make konversation window come out.. such is why I was looking for the menu :) since click will not pop it up.

@4e554c4c
Copy link
Contributor

@ReK2Fernandez This entire system is being reworked. Please test again once #1431 is merged.

@r3k2
Copy link

r3k2 commented Dec 23, 2017

Hey thanks for responding... hmm and when is this happening? can I compile it myself ? whats the branch name so I can pull it?

@4e554c4c
Copy link
Contributor

4e554c4c commented Dec 23, 2017

The branch is sni_sucks on https://github.com/4e554c4c/sway. You can compile it and test, but as I said it's still being reworked.

@r3k2
Copy link

r3k2 commented Dec 23, 2017

lol :) ok I may, as a work around I am running keybase and enpass on their own workspaces .. but that "alsosucks" :)

@ianyfan ianyfan mentioned this issue Dec 7, 2018
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

6 participants