Implement input_method_v2 popups #5890

tadeokondrak · 2020-12-16T04:35:25Z

Depends on ~~#4932~~, ~~swaywm/wlroots#2550~~ and ~~https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3416~~.
~~swaywm/wlroots#2697~~, ~~#5980~~, ~~#6004~~, and ~~#6005~~ are related but not required.

sway/desktop/render.c

12101111 · 2021-01-25T06:56:30Z

sway crash on exit

  * frame #0: 0x00007fcc2418f6a7 libwayland-server.so.0`wl_list_remove(elm=0x00007fcc1bd2dd98) at wayland-util.c:55:18
    frame #1: 0x00007fcc2413a06a libwlroots.so.7`xdg_popup_grab_handle_seat_destroy(listener=<unavailable>, data=<unavailable>) at wlr_xdg_popup.c:158:2
    frame #2: 0x00007fcc2416634c libwlroots.so.7`wlr_signal_emit_safe(signal=<unavailable>, data=0x00007fcc1c04e050) at signal.c:29:3
    frame #3: 0x00007fcc24134e88 libwlroots.so.7`wlr_seat_destroy(seat=0x00007fcc1c04e050) at wlr_seat.c:170:2
    frame #4: 0x00007fcc2418975f libwayland-server.so.0`wl_display_destroy [inlined] wl_priv_signal_final_emit(signal=0x00007fcc245fce88, data=0x00007fcc245fce20) at wayland-server.c:2157:3
    frame #5: 0x00007fcc24189728 libwayland-server.so.0`wl_display_destroy(display=0x00007fcc245fce20) at wayland-server.c:1134
    frame #6: 0x00005589ae2246a3 sway`server_fini(server=0x00005589ae2825d0) at server.c:203:2
    frame #7: 0x00005589ae223dee sway`main(argc=1, argv=0x00007ffd55a5e338) at main.c:436:2
    frame #8: 0x00007fcc247c0129 ld-musl-x86_64.so.1`libc_start_main_stage2(main=(sway`main at main.c:245), argc=<unavailable>, argv=0x00007ffd55a5e338) at __libc_start_main.c:94:7
    frame #9: 0x00005589ae216eb6 sway`_start + 22

another crash

* thread #1, name = 'sway', stop reason = signal SIGSEGV
  * frame #0: 0x000055bfceadf096 sway`desktop_damage_view at desktop.c:0:2
    frame #1: 0x000055bfceadf05e sway`desktop_damage_view(view=0x00007f1b143dd2d0) at desktop.c:38
    frame #2: 0x000055bfceafd400 sway`input_popup_update [inlined] input_popup_damage(popup=<unavailable>) at text_input.c:36:2
    frame #3: 0x000055bfceafd3e8 sway`input_popup_update(popup=0x00007f1b13c4fac0) at text_input.c:40
    frame #4: 0x00007f1b1fec5f8c libwlroots.so.7`wlr_signal_emit_safe(signal=<unavailable>, data=0x00007f1b1355a790) at signal.c:29:3
    frame #5: 0x000055bfceafcb29 sway`handle_text_input_enable(listener=<unavailable>, data=<unavailable>) at text_input.c:260:2
    frame #6: 0x00007f1b1fec5f8c libwlroots.so.7`wlr_signal_emit_safe(signal=<unavailable>, data=0x00007f1b1439db10) at signal.c:29:3
    frame #7: 0x00007f1b1f9016b5 libffi.so.7`___lldb_unnamed_symbol3$$libffi.so.7 + 85
    frame #8: 0x00007f1b1f905c6e libffi.so.7`___lldb_unnamed_symbol19$$libffi.so.7 + 750
    frame #9: 0x00007f1b1feee664 libwayland-server.so.0`wl_closure_invoke(closure=0x00007f1b144155c0, flags=<unavailable>, target=<unavailable>, opcode=7, data=<unavailable>) at connection.c:1018:2
    frame #10: 0x00007f1b1fee8958 libwayland-server.so.0`wl_client_connection_data(fd=<unavailable>, mask=<unavailable>, data=<unavailable>) at wayland-server.c:432:4
    frame #11: 0x00007f1b1feecd3c libwayland-server.so.0`wl_event_loop_dispatch(loop=<unavailable>, timeout=<unavailable>) at event-loop.c:1027:4
    frame #12: 0x00007f1b1fee9bad libwayland-server.so.0`wl_display_run(display=0x00007f1b20324c20) at wayland-server.c:1351:3
    frame #13: 0x000055bfceaddcf1 sway`main [inlined] server_run(server=<unavailable>) at server.c:247:2
    frame #14: 0x000055bfceaddcbf sway`main(argc=1, argv=0x00007ffe7aa881c8) at main.c:431
    frame #15: 0x00007f1b20520129 ld-musl-x86_64.so.1`libc_start_main_stage2(main=(sway`main at main.c:245), argc=<unavailable>, argv=0x00007ffe7aa881c8) at __libc_start_main.c:94:7
    frame #16: 0x000055bfcead0e16 sway`_start + 22

emersion · 2021-03-12T11:26:36Z

#4932 has been merged now, so this needs a rebase.

Foot and alacritty no longer crashes.

JingMatrix · 2022-03-31T08:34:26Z

I apply this PR with the current HEAD.
The api of wlr_output_layout_get_box has changed, so you should change your code a bit in sway/sway/input/text_input.c.
After this, I compiled your code, and tested it with alacritty and kitty, both gave me the same result:
the popup showed up at the very beginning, and then never showed up again.

dragove · 2022-04-05T15:50:09Z

I've tested it with AUR package sway-im with fcitx5 as input method in kitty. When the character meets the end of a line, the popup will be hidden. I don't know if it is a issue with kitty. Alacritty won't meet this issue since it won't put characters into the line before I select my needed word in IM.
Edit: This problem only shows up when I set default_border none 0 in sway configuration file.

JingMatrix · 2022-04-07T20:44:25Z

Now I test it ( after fixing the output_box api problem) with the HEAD of fcitx5 and HEAD of sway, everything works!

Legogris · 2022-04-12T05:08:38Z

@emersion Looks like this is ready for another review :)

emersion · 2022-05-11T14:11:10Z

sway/tree/container.c

@@ -395,6 +395,8 @@ static bool surface_is_popup(struct wlr_surface *surface) {
 			wlr_subsurface_from_wlr_surface(surface);
 		surface = subsurface->parent;
 	}
+	if (wlr_surface_is_input_popup_surface_v2(surface))


Style: braces are mandatory

emersion · 2022-05-11T14:12:37Z

sway/input/cursor.c

@@ -139,6 +161,11 @@ struct sway_node *node_at_coords(
 		return NULL;
 	}

+	if ((*surface = input_popup_surface_at(output,


We should probably move this up right before "check for unmanaged views" to allow fullscreen surfaces to work with IMEs.

emersion · 2022-05-11T14:14:36Z

sway/input/cursor.c

+			continue;
+		}
+		double _sx = ox - lx;
+		double _sy = oy - ly;


This mixes up layout-local coords and output-local coords. I think input_popup_surface_at should take layout-local coords instead.

emersion · 2022-05-11T14:18:51Z

sway/input/text_input.c

+	wl_signal_add(&view->events.unmap, &popup->focused_surface_unmap);
+
+	// Since the focus has changed, the popup may have to adjust
+update_popup:


Instead of a goto, else if/else would be more readable.

emersion · 2022-05-11T14:22:07Z

sway/input/text_input.c

+
+	struct sway_view *view = view_from_wlr_surface(
+		text_input->input->focused_surface);
+	if (view->container == NULL) {


This can return NULL here.

This logic doesn't work on subsurfaces nor xdg_popups.

Based on swaywm/sway#5890

evanslify · 2022-08-07T08:09:03Z

@tadeokondrak @emersion This PR seems to have some amendments pending. Can I take over by starting another PR?

Based on swaywm/sway#5890 Co-authored-by: Leonardo Hernández Hernández <leohdz172@protonmail.com>

flibitijibibo · 2022-11-23T04:08:29Z

Someone has been testing this with SDL and it seems there's an issue with fcitx, but only when integer scaling is used...?

libsdl-org/SDL#5892

We have some ideas on our end, but figured we'd include the issue here in case it's something obvious on the compositor side of things.

tadeokondrak · 2022-11-23T11:42:08Z

Sorry about this PR... I've left it open because I thought I could get to it eventually - but it looks like someone else is continuing the effort at #7226, which is great.

Decodetalkers · 2022-11-23T16:00:17Z

Sorry about this PR... I've left it open because I thought I could get to it eventually - but it looks like someone else is continuing the effort at #7226, which is great.

Thanks that you have return back..Your help is still needed..Do you still have time now?

Decodetalkers · 2022-11-25T07:51:13Z

Sorry about this PR... I've left it open because I thought I could get to it eventually - but it looks like someone else is continuing the effort at #7226, which is great.

This mixes up layout-local coords and output-local coords. I think input_popup_surface_at should take layout-local coords instead.

I do not know how to make change about this request, can you help me?

tadeokondrak force-pushed the input-method-popups branch 3 times, most recently from 95af575 to e399a4c Compare December 16, 2020 20:09

tadeokondrak force-pushed the input-method-popups branch 2 times, most recently from b94a50b to 7478170 Compare January 2, 2021 19:24

ngkz reviewed Jan 7, 2021

View reviewed changes

sway/desktop/render.c Outdated Show resolved Hide resolved

wengxt mentioned this pull request Jan 19, 2021

Wayland status? fcitx/fcitx5#206

Closed

Riey mentioned this pull request Jan 22, 2021

Add Wayland frontend Riey/kime#43

Closed

2 tasks

tadeokondrak force-pushed the input-method-popups branch 4 times, most recently from 36357ee to ce391ee Compare January 23, 2021 22:35

tadeokondrak force-pushed the input-method-popups branch 9 times, most recently from 381e7e0 to fdaf0db Compare January 30, 2021 02:23

tadeokondrak marked this pull request as ready for review January 30, 2021 02:27

tadeokondrak force-pushed the input-method-popups branch 2 times, most recently from 03d8ee8 to 987d8dc Compare February 8, 2021 18:31

Riey mentioned this pull request Feb 12, 2021

Update protocol from wlroots pentamassiv/zwp-input-method#1

Closed

tadeokondrak force-pushed the input-method-popups branch from 987d8dc to 227d34d Compare February 18, 2021 18:35

12101111 mentioned this pull request Mar 1, 2021

Port input method and text input from rootston #4740

Merged

tadeokondrak force-pushed the input-method-popups branch from 227d34d to 4edc70f Compare March 12, 2021 16:33

chuangzhu added a commit to chuangzhu/nixpkgs that referenced this pull request Feb 25, 2022

sway: pick patch from swaywm/sway#5890

0256871

Foot and alacritty no longer crashes.

JingMatrix mentioned this pull request Apr 8, 2022

IME: put cursor after rendered text kovidgoyal/kitty#4937

Merged

text_input: Implement input-method popups

100ac12

tadeokondrak force-pushed the input-method-popups branch from 9debeb4 to 100ac12 Compare April 12, 2022 12:46

emersion reviewed May 11, 2022

View reviewed changes

Shugyousha added a commit to Shugyousha/dwl that referenced this pull request May 15, 2022

implement input popup rendering

826daf5

Based on swaywm/sway#5890

Shugyousha added a commit to Shugyousha/dwl that referenced this pull request May 15, 2022

implement input popup rendering

27bf627

Based on swaywm/sway#5890

wengxt mentioned this pull request Jun 2, 2022

Input window no longer visible on Sway with 5.0.17 (Japanese) fcitx/fcitx5#505

Closed

layercak3 mentioned this pull request Jul 5, 2022

[Wayland] Candidate list for Fcitx5 immediately disappears/flickers in fullscreen windows (text-input-v3) libsdl-org/SDL#5892

Closed

wengxt mentioned this pull request Jul 16, 2022

wayland: support text-input-v3 for IME wez/wezterm#1772

Closed

YHNdnzj mentioned this pull request Sep 8, 2022

Can't clear preedit text when using inline IME alacritty/alacritty#6313

Closed

sevz17 added a commit to sevz17/dwl that referenced this pull request Sep 30, 2022

implement input popup rendering

ba92620

Based on swaywm/sway#5890 Co-authored-by: Leonardo Hernández Hernández <leohdz172@protonmail.com>

Decodetalkers mentioned this pull request Oct 17, 2022

text_input: Implement input-method popups #7226

Merged

emersion removed this from the 1.8 milestone Nov 11, 2022

tadeokondrak closed this Nov 23, 2022

rvaiya mentioned this pull request Nov 24, 2022

Blinking cursor_color in normal mode rvaiya/warpd#174

Open

wengxt mentioned this pull request Dec 15, 2022

gentoo+sway无法在WPS、foot、dingtalk应用中显示输入法候选窗口 fcitx/fcitx5#455

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement input_method_v2 popups #5890

Implement input_method_v2 popups #5890

tadeokondrak commented Dec 16, 2020 •

edited

Loading

12101111 commented Jan 25, 2021 •

edited

Loading

emersion commented Mar 12, 2021

JingMatrix commented Mar 31, 2022

dragove commented Apr 5, 2022 •

edited

Loading

JingMatrix commented Apr 7, 2022

Legogris commented Apr 12, 2022

emersion May 11, 2022

emersion May 11, 2022

emersion May 11, 2022

emersion May 11, 2022

emersion May 11, 2022

evanslify commented Aug 7, 2022

flibitijibibo commented Nov 23, 2022

tadeokondrak commented Nov 23, 2022

Decodetalkers commented Nov 23, 2022

Decodetalkers commented Nov 25, 2022

Implement input_method_v2 popups #5890

Implement input_method_v2 popups #5890

Conversation

tadeokondrak commented Dec 16, 2020 • edited Loading

12101111 commented Jan 25, 2021 • edited Loading

emersion commented Mar 12, 2021

JingMatrix commented Mar 31, 2022

dragove commented Apr 5, 2022 • edited Loading

JingMatrix commented Apr 7, 2022

Legogris commented Apr 12, 2022

emersion May 11, 2022

Choose a reason for hiding this comment

emersion May 11, 2022

Choose a reason for hiding this comment

emersion May 11, 2022

Choose a reason for hiding this comment

emersion May 11, 2022

Choose a reason for hiding this comment

emersion May 11, 2022

Choose a reason for hiding this comment

evanslify commented Aug 7, 2022

flibitijibibo commented Nov 23, 2022

tadeokondrak commented Nov 23, 2022

Decodetalkers commented Nov 23, 2022

Decodetalkers commented Nov 25, 2022

tadeokondrak commented Dec 16, 2020 •

edited

Loading

12101111 commented Jan 25, 2021 •

edited

Loading

dragove commented Apr 5, 2022 •

edited

Loading