Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer-shell: implement on-demand keyboard interactivity #5974

Closed
wants to merge 1 commit into from

Conversation

alebastr
Copy link
Contributor

I'm still not sure if the approach with seat_set_focus_surface is right but on-demand surface is definitely not expected to set seat->focused_layer.

Basic cases tested with gtk-layer-demo:

  • xdg toplevel + layer-surface/top/on-demand:
    Input focus can be switched between the surfaces
  • xdg toplevel + layer-surface/top/on-demand + layer-surface/top/exclusive:
    Focus can be switched between two layer surfaces. xdg surface does not get focus
  • xdg toplevel + layer-surface/top/on-demand + layer-surface/overlay/exclusive:
    Contrary to my expectations, both layer surfaces can get focus. xdg surface is still ignored
  • focus_follows_mouse: keyboard focus is released on wl_pointer.leave; keyboard focus is not received on wl_pointer.enter. The code for that is still missing.
  • return keyboard focus after destroying on-demand layer surface:
    That part is definitely buggy. There's no keyboard focus after destroying on-demand layer surface.

@emersion emersion added the enhancement New feature or incremental improvement label Dec 21, 2021
@alebastr alebastr closed this Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or incremental improvement
Development

Successfully merging this pull request may close these issues.

2 participants