Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only submit password if previous validation completed #375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only submit password if previous validation completed #375

wants to merge 1 commit into from

Commits on Sep 19, 2024

  1. Only submit password if previous validation completed 

    This averts the risk that one can queue up many password submissions
by pressing enter repeatedly (or with key repeat, holding enter),
much more quickly than PAM will process them. It may also improve
usability by reducing unrevealed system state: now that at most one
password can be queued, the "Verifying" message is always shown when
a password is being validated.

However, this commit does introduce a minor UI issue: if one types
an invalid second password just slightly faster than PAM validation
completes, it may fail to submit, and the signs of this may be hard
to notice (state transition timing, presence of keypress indicator,
and (if enabled) attempt count).
    @mstoeckl
    mstoeckl committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4846fa7 View commit details
    Browse the repository at this point in the history