This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
output: don't destroy global immediately #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
output-global-workaround
branch
from
5ba4df5
to
7144017
Compare
emersion
changed the title
emersion
force-pushed
the
output-global-workaround
branch
from
7144017
to
ce73701
Compare
|
What's the reason this is marked as "do not merge"? Because it depends on a new wayland feature or because it needs more testing? |
|
Blocked on a new Wayland release. |
|
Can we make a more generalized helper for delaying global destruction for any kind of global? |
emersion
changed the title
This adds a generic helper to destory transient globals. See [1]. This patch depends on [2] and [3]. [1]: https://gitlab.freedesktop.org/wayland/wayland/issues/10 [2]: https://gitlab.freedesktop.org/wayland/wayland/merge_requests/28 [3]: https://gitlab.freedesktop.org/wayland/wayland/merge_requests/30
emersion
force-pushed
the
output-global-workaround
branch
from
ce73701
to
00d322b
Compare
|
Wayland 1.18 has been released, so we'll soon be able to (finally!) land this. This PR is ready for review.
Yeah that's a good idea. Pushed a commit doing that a while ago. |
ddevault
approved these changes
Feb 17, 2020
|
Thanks! |
|
I had I hopes for this PR to fix firefox crashes on reload. Sadly, my firefox still crashes on |
|
Hard to say without a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Build with Wayland's master branch.
Closes: swaywm/sway#3625