Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): Call swc_common::GLOBALS.set in css minify #44

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

neoGeneva
Copy link
Contributor

Currently errors generate in the minification process get obscured because of error in the error handling because of a missing global.

I've added a call to swc_common::GLOBALS.set(&swc_common::Globals::new(), || { in minify_inner of css_node/src/lib.rs in the same way it's set in html_node/src/lib.rs

I'm not sure, but suspect linter_node will need a similar change.

Copy link

changeset-bot bot commented Feb 28, 2024

⚠️ No Changeset found

Latest commit: 045dbb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Feb 28, 2024

CLA assistant check
All committers have signed the CLA.

@kdy1 kdy1 changed the title Call swc_common::GLOBALS.set in css minify fix(css): Call swc_common::GLOBALS.set in css minify Feb 28, 2024
@kdy1 kdy1 enabled auto-merge (squash) February 28, 2024 03:39
@kdy1 kdy1 self-assigned this Feb 28, 2024
@kdy1 kdy1 merged commit da2f794 into swc-project:main Feb 28, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants