fix(es/helpers): Override mistake in _interop_require_wildcard (#8076)

**Related issue:** - babel/babel#15995
swc-project · Oct 7, 2023 · 1346528 · 1346528 · github-actions · Oct 7, 2023
1 parent 4843266
commit 1346528
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/crates/swc_ecma_transforms_base/src/helpers/_interop_require_wildcard.js b/crates/swc_ecma_transforms_base/src/helpers/_interop_require_wildcard.js
@@ -17,7 +17,7 @@ function _interop_require_wildcard(obj, nodeInterop) {
     if (cache && cache.has(obj)) {
         return cache.get(obj);
     }
-    var newObj = {};
+    var newObj = { __proto__: null };
     var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor;
     for (var key in obj) {
         if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) {

diff --git a/packages/helpers/esm/_interop_require_wildcard.js b/packages/helpers/esm/_interop_require_wildcard.js
@@ -16,7 +16,7 @@ export function _interop_require_wildcard(obj, nodeInterop) {
 
     if (cache && cache.has(obj)) return cache.get(obj);
 
-    var newObj = {};
+    var newObj = { __proto__: null };
     var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor;
 
     for (var key in obj) {
Benchmark suite	Current: `1346528`	Previous: `a5621bb`	Ratio
`es/full/bugs-1`	`278775` ns/iter (`± 3622`)	`280845` ns/iter (`± 5860`)	`0.99`
`es/full/minify/libraries/antd`	`1348747650` ns/iter (`± 20880960`)	`1357036999` ns/iter (`± 18784396`)	`0.99`
`es/full/minify/libraries/d3`	`279315887` ns/iter (`± 2735956`)	`281341385` ns/iter (`± 4329391`)	`0.99`
`es/full/minify/libraries/echarts`	`1085681060` ns/iter (`± 10609841`)	`1095010989` ns/iter (`± 10189978`)	`0.99`
`es/full/minify/libraries/jquery`	`85266846` ns/iter (`± 491540`)	`85178939` ns/iter (`± 404071`)	`1.00`
`es/full/minify/libraries/lodash`	`98390273` ns/iter (`± 338484`)	`98903050` ns/iter (`± 466814`)	`0.99`
`es/full/minify/libraries/moment`	`50482707` ns/iter (`± 295110`)	`50324663` ns/iter (`± 247772`)	`1.00`
`es/full/minify/libraries/react`	`18090868` ns/iter (`± 84462`)	`18116955` ns/iter (`± 137227`)	`1.00`
`es/full/minify/libraries/terser`	`224326908` ns/iter (`± 1727218`)	`223023246` ns/iter (`± 1888422`)	`1.01`
`es/full/minify/libraries/three`	`398686673` ns/iter (`± 3023189`)	`398650130` ns/iter (`± 4285511`)	`1.00`
`es/full/minify/libraries/typescript`	`2694968376` ns/iter (`± 16756286`)	`2717859407` ns/iter (`± 11167799`)	`0.99`
`es/full/minify/libraries/victory`	`607050069` ns/iter (`± 5494820`)	`597919029` ns/iter (`± 7420239`)	`1.02`
`es/full/minify/libraries/vue`	`122245938` ns/iter (`± 1106682`)	`121041834` ns/iter (`± 761097`)	`1.01`
`es/full/codegen/es3`	`34444` ns/iter (`± 107`)	`34400` ns/iter (`± 299`)	`1.00`
`es/full/codegen/es5`	`34379` ns/iter (`± 54`)	`34419` ns/iter (`± 153`)	`1.00`
`es/full/codegen/es2015`	`34370` ns/iter (`± 68`)	`34186` ns/iter (`± 156`)	`1.01`
`es/full/codegen/es2016`	`34280` ns/iter (`± 67`)	`34377` ns/iter (`± 186`)	`1.00`
`es/full/codegen/es2017`	`34466` ns/iter (`± 70`)	`34394` ns/iter (`± 232`)	`1.00`
`es/full/codegen/es2018`	`34399` ns/iter (`± 79`)	`34522` ns/iter (`± 118`)	`1.00`
`es/full/codegen/es2019`	`34376` ns/iter (`± 81`)	`34404` ns/iter (`± 94`)	`1.00`
`es/full/codegen/es2020`	`34410` ns/iter (`± 75`)	`34554` ns/iter (`± 117`)	`1.00`
`es/full/all/es3`	`166827572` ns/iter (`± 4196051`)	`170301288` ns/iter (`± 904262`)	`0.98`
`es/full/all/es5`	`158481136` ns/iter (`± 3917806`)	`161837986` ns/iter (`± 774702`)	`0.98`
`es/full/all/es2015`	`119137280` ns/iter (`± 829015`)	`120694176` ns/iter (`± 940088`)	`0.99`
`es/full/all/es2016`	`118384259` ns/iter (`± 2056572`)	`120372689` ns/iter (`± 349689`)	`0.98`
`es/full/all/es2017`	`117639772` ns/iter (`± 861769`)	`119199531` ns/iter (`± 929159`)	`0.99`
`es/full/all/es2018`	`115718330` ns/iter (`± 861068`)	`117290881` ns/iter (`± 679843`)	`0.99`
`es/full/all/es2019`	`114049899` ns/iter (`± 1136600`)	`116529341` ns/iter (`± 801581`)	`0.98`
`es/full/all/es2020`	`110258029` ns/iter (`± 1869779`)	`112735829` ns/iter (`± 542268`)	`0.98`
`es/full/parser`	`512638` ns/iter (`± 5080`)	`514570` ns/iter (`± 5594`)	`1.00`
`es/full/base/fixer`	`18063` ns/iter (`± 134`)	`17766` ns/iter (`± 71`)	`1.02`
`es/full/base/resolver_and_hygiene`	`81232` ns/iter (`± 229`)	`79821` ns/iter (`± 277`)	`1.02`