Fix perfer-const

swc-project · Jan 30, 2024 · c58349f · c58349f
1 parent 4e01616
commit c58349f
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/crates/swc_ecma_lints/src/rules/prefer_const.rs b/crates/swc_ecma_lints/src/rules/prefer_const.rs
@@ -235,11 +235,15 @@ impl Visit for PreferConst {
 
     fn visit_assign_expr(&mut self, assign_expr: &AssignExpr) {
         if let op!("=") = assign_expr.op {
-            if let AssignTarget::Pat(pat) = &assign_expr.left {
-                match pat {
+            match &assign_expr.left {
+                AssignTarget::Simple(SimpleAssignTarget::Ident(l)) => {
+                    self.consider_mutation_for_ident(l, false);
+                }
+
+                AssignTarget::Pat(pat) => match pat {
                     AssignTargetPat::Array(ArrayPat { elems, .. }) => {
                         elems.iter().flatten().for_each(|elem| {
-                            self.consider_mutation(elem, false);
+                            self.consider_mutation(elem, true);
                         })
                     }
                     AssignTargetPat::Object(ObjectPat { props, .. }) => {
@@ -254,7 +258,8 @@ impl Visit for PreferConst {
                         });
                     }
                     AssignTargetPat::Invalid(_) => {}
-                }
+                },
+                _ => (),
             }
         }