fix(bundler): Fix bugs #1382

kdy1 · 2021-02-08T04:18:36Z

Issues

Tasks

swc_bundler:

Improve performance
Use Vec<AHashSet<usize>> instead of AHashSet<(usize, usize)>.
Fix statement orderings. (deno 1.7.2 : deno bundle error denoland/deno#9464)
Fix wrapped esm mixed with circular imports. (Bundling has infinite loop with certain circular dependency scenarios denoland/deno#8224)
Store content of wrapped esm at top level. (Bundling has infinite loop with certain circular dependency scenarios denoland/deno#8224)

Performance

OS: Ubuntu 18.04
CPU: zeon e3-1275 v2.

Initial time for 8597

4.62 sec

After using fxhash while sorting

3.341 sec

The output of perf:

+   91.72%     0.00%  deno_8597        [unknown]              [.] 0xffffffffffffffff
+   59.36%    36.46%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::modules::sort::graph::StmtDepGraph::insert_transitives
+   37.54%     0.00%  deno_8597        deno-22488d47eece7722  [.] scoped_tls::ScopedKey<T>::set (inlined)
+   37.54%     0.00%  deno_8597        deno-22488d47eece7722  [.] testing::run_test2::_$u7b$$u7b$closure$u7d$$u7d$::hff268ba00ad75d70 (inlined)
+   37.54%     0.00%  deno_8597        deno-22488d47eece7722  [.] deno::bundle::_$u7b$$u7b$closure$u7d$$u7d$::hf1eebaecc2226714 (inlined)
+   37.54%     0.00%  deno_8597        deno-22488d47eece7722  [.] scoped_tls::ScopedKey<T>::with (inlined)
+   37.54%     0.00%  deno_8597        deno-22488d47eece7722  [.] deno::bundle::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h79ecdcf6a27ee30c (inlined)
+   37.53%     0.00%  deno_8597        deno-22488d47eece7722  [.] testing::run_test2
+   36.79%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::Bundler<L,R>::bundle (inlined)
+   34.10%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::Bundler<L,R>::run (inlined)
+   31.27%     0.00%  deno_8597        deno-22488d47eece7722  [.] deno::run
+   28.64%     0.09%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::modules::sort::<impl swc_bundler::bundler::modules::Modules>::sort
+   28.08%     0.00%  deno_8597        deno-22488d47eece7722  [.] deno::bundle (inlined)
+   28.07%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::chunk::merge::<impl swc_bundler::bundler::Bundler<L,R>>::finalize_merging_of_entry
+   27.98%     0.00%  deno_8597        deno-22488d47eece7722  [.] core::iter::traits::iterator::Iterator::collect (inlined)
+   27.98%     0.00%  deno_8597        deno-22488d47eece7722  [.] <alloc::vec::Vec<T> as core::iter::traits::collect::FromIterator<T>>::from_iter (inlined)
+   27.98%     0.00%  deno_8597        deno-22488d47eece7722  [.] <alloc::vec::Vec<T> as alloc::vec::SpecFromIter<T,I>>::from_iter (inlined)
+   27.98%     0.00%  deno_8597        deno-22488d47eece7722  [.] <alloc::vec::Vec<T> as alloc::vec::SpecFromIterNested<T,I>>::from_iter (inlined)
+   27.96%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::Bundler<L,R>::run
+   27.96%     0.00%  deno_8597        deno-22488d47eece7722  [.] scoped_tls::ScopedKey<T>::set (inlined)
+   27.96%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::chunk::merge::_$LT$impl$u20$swc_bundler..bundler..Bundler$LT$L$C$R$GT$$GT$::merge_modules::_$u7b$$u7b$closure$u7d$$u
+   26.41%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::chunk::<impl swc_bundler::bundler::Bundler<L,R>>::chunk (inlined)
+   25.85%     0.00%  deno_8597        deno-22488d47eece7722  [.] <alloc::vec::Vec<T,A> as alloc::vec::SpecExtend<T,I>>::spec_extend (inlined)
+   25.85%     0.00%  deno_8597        deno-22488d47eece7722  [.] core::iter::traits::iterator::Iterator::for_each (inlined)
+   25.85%     0.00%  deno_8597        deno-22488d47eece7722  [.] <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::fold (inlined)
+   25.85%     0.00%  deno_8597        deno-22488d47eece7722  [.] core::iter::traits::iterator::Iterator::fold (inlined)
+   25.85%     0.00%  deno_8597        deno-22488d47eece7722  [.] core::iter::adapters::map::map_fold::_$u7b$$u7b$closure$u7d$$u7d$::h2cb29352f03db3cb (inlined)
+   25.85%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::chunk::_$LT$impl$u20$swc_bundler..bundler..Bundler$LT$L$C$R$GT$$GT$::chunk::_$u7b$$u7b$closure$u7d$$u7d$::h60c8f346e
+   25.85%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::chunk::_$LT$impl$u20$swc_bundler..bundler..Bundler$LT$L$C$R$GT$$GT$::chunk::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b
+   25.85%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::chunk::merge::<impl swc_bundler::bundler::Bundler<L,R>>::merge_modules (inlined)
+   15.91%     4.34%  deno_8597        deno-22488d47eece7722  [.] core::iter::traits::iterator::Iterator::collect
+    9.99%     9.99%  deno_8597        [kernel.kallsyms]      [k] nmi
+    8.25%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::finalize::<impl swc_bundler::bundler::Bundler<L,R>>::finalize (inlined)
+    8.25%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_bundler::bundler::finalize::_$LT$impl$u20$swc_bundler..bundler..Bundler$LT$L$C$R$GT$$GT$::finalize::_$u7b$$u7b$closure$u7d$$u7d$::h643
+    8.25%     0.00%  deno_8597        deno-22488d47eece7722  [.] <swc_ecma_ast::module::Module as swc_ecma_visit::FoldWith<V>>::fold_with (inlined)
+    8.25%     0.00%  deno_8597        deno-22488d47eece7722  [.] <swc_ecma_visit::Folder<V> as swc_ecma_visit::Fold>::fold_module (inlined)
+    8.25%     0.00%  deno_8597        deno-22488d47eece7722  [.] <swc_ecma_ast::module::Module as swc_ecma_visit::VisitMutWith<V>>::visit_mut_with (inlined)
+    8.04%     0.00%  deno_8597        deno-22488d47eece7722  [.] <swc_visit::AndThen<A,B> as swc_ecma_visit::Fold>::fold_module (inlined)
+    7.25%     0.01%  deno_8597        deno-22488d47eece7722  [.] swc_ecma_parser::parser::expr::<impl swc_ecma_parser::parser::Parser<I>>::parse_assignment_expr
+    7.00%     0.00%  deno_8597        deno-22488d47eece7722  [.] <swc_ecma_transforms_base::hygiene::Hygiene as swc_ecma_visit::VisitMut>::visit_mut_module
+    6.75%     0.01%  deno_8597        deno-22488d47eece7722  [.] swc_ecma_parser::parser::expr::<impl swc_ecma_parser::parser::Parser<I>>::parse_assignment_expr_base
+    6.64%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_ecma_parser::parser::expr::<impl swc_ecma_parser::parser::Parser<I>>::parse_cond_expr (inlined)
+    6.64%     0.08%  deno_8597        deno-22488d47eece7722  [.] swc_ecma_transforms_base::hygiene::Hygiene::add_declared_ref
+    6.52%     0.12%  deno_8597        deno-22488d47eece7722  [.] swc_ecma_parser::parser::expr::ops::<impl swc_ecma_parser::parser::Parser<I>>::parse_unary_expr
+    6.46%     0.27%  deno_8597        deno-22488d47eece7722  [.] swc_ecma_parser::parser::expr::<impl swc_ecma_parser::parser::Parser<I>>::parse_lhs_expr
+    6.44%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_ecma_transforms_base::hygiene::Hygiene::rename
+    6.44%     0.00%  deno_8597        deno-22488d47eece7722  [.] swc_ecma_parser::parser::expr::ops::<impl swc_ecma_parser::parser::Parser<I>>::parse_bin_expr
+    6.43%     0.00%  deno_8597        libc-2.27.so           [.] __GI___libc_malloc (inlined)
+    6.41%     6.21%  deno_8597        deno-22488d47eece7722  [.] swc_ecma_transforms_base::hygiene::Scope::is_declared
+    6.05%     0.01%  deno_8597        deno-22488d47eece7722  [.] swc_ecma_transforms_base::hygiene::Hygiene::visit_mut_fn
+    6.02%     0.00%  deno_8597        deno-22488d47eece7722  [.] <swc_ecma_transforms_base::hygiene::Hygiene as swc_ecma_visit::VisitMut>::visit_mut_fn_decl
+    5.62%     0.16%  deno_8597        deno-22488d47eece7722  [.] swc_ecma_parser::parser::expr::<impl swc_ecma_parser::parser::Parser<I>>::parse_member_expr_or_new_expr

After using ahash and faster graph

+   79.04%     0.00%  deno_8597        [unknown]              [k] 0xffffffffffffffff                                                                                                                       ◆
+   51.09%    16.96%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::modules::sort::graph::StmtDepGraph::insert_transitives                                                             ▒
+   35.64%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] deno::bundle::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h33b13ccd96719fac                                              ▒
+   34.71%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::Bundler<L,R>::bundle (inlined)                                                                                     ▒
+   31.73%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::chunk::<impl swc_bundler::bundler::Bundler<L,R>>::chunk (inlined)                                                  ▒
+   28.52%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::Bundler<L,R>::run (inlined)                                                                                        ▒
+   28.52%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] scoped_tls::ScopedKey<T>::set (inlined)                                                                                                  ▒
+   27.46%     0.32%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::modules::sort::<impl swc_bundler::bundler::modules::Modules>::sort                                                 ▒
+   27.40%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::chunk::merge::<impl swc_bundler::bundler::Bundler<L,R>>::finalize_merging_of_entry                                 ▒
+   27.18%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::Bundler<L,R>::run                                                                                                  ▒
+   27.18%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] scoped_tls::ScopedKey<T>::set (inlined)                                                                                                  ▒
+   27.18%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::chunk::merge::_$LT$impl$u20$swc_bundler..bundler..Bundler$LT$L$C$R$GT$$GT$::merge_modules::_$u7b$$u7b$closure$u7d$$▒
+   25.90%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] core::iter::traits::iterator::Iterator::collect (inlined)                                                                                ▒
+   25.90%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <alloc::vec::Vec<T> as core::iter::traits::collect::FromIterator<T>>::from_iter (inlined)                                                ▒
+   25.90%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <alloc::vec::Vec<T> as alloc::vec::SpecFromIter<T,I>>::from_iter (inlined)                                                               ▒
+   25.90%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <alloc::vec::Vec<T> as alloc::vec::SpecFromIterNested<T,I>>::from_iter (inlined)                                                         ▒
+   25.72%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <alloc::vec::Vec<T,A> as alloc::vec::SpecExtend<T,I>>::spec_extend (inlined)                                                             ▒
+   25.72%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] core::iter::traits::iterator::Iterator::for_each (inlined)                                                                               ▒
+   25.72%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::fold (inlined)                                          ▒
+   25.72%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] core::iter::traits::iterator::Iterator::fold (inlined)                                                                                   ▒
+   25.72%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] core::iter::adapters::map::map_fold::_$u7b$$u7b$closure$u7d$$u7d$::h882e8545b9962f60 (inlined)                                           ▒
+   25.72%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::chunk::_$LT$impl$u20$swc_bundler..bundler..Bundler$LT$L$C$R$GT$$GT$::chunk::_$u7b$$u7b$closure$u7d$$u7d$::h5441d689▒
+   25.72%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::chunk::_$LT$impl$u20$swc_bundler..bundler..Bundler$LT$L$C$R$GT$$GT$::chunk::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7▒
+   25.49%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::chunk::merge::<impl swc_bundler::bundler::Bundler<L,R>>::merge_modules (inlined)                                   ▒
+   23.62%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] deno::bundle                                                                                                                             ▒
+   23.62%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] testing::run_test2 (inlined)                                                                                                             ▒
+   23.62%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] scoped_tls::ScopedKey<T>::set (inlined)                                                                                                  ▒
+   23.62%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] testing::run_test2::_$u7b$$u7b$closure$u7d$$u7d$::h6361bf4a3fe8f6b8 (inlined)                                                            ▒
+   23.62%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] scoped_tls::ScopedKey<T>::with (inlined)                                                                                                 ▒
+   23.62%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] deno::bundle::_$u7b$$u7b$closure$u7d$$u7d$::h7702375601e5c80e (inlined)                                                                  ▒
+   21.88%    19.65%  deno_8597        deno-8b0513ef89be7c6d  [.] std::collections::hash::set::HashSet<T,S>::insert                                                                                        ▒
+   12.32%     2.07%  deno_8597        deno-8b0513ef89be7c6d  [.] alloc::vec::Vec<T,A>::reserve                                                                                                            ▒
+   12.09%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] deno::run                                                                                                                                ▒
+   11.20%     0.00%  deno_8597        libc-2.27.so           [.] __memcpy_sse2_unaligned_erms (inlined)                                                                                                   ▒
+   11.10%    11.10%  deno_8597        libc-2.27.so           [.] __memmove_sse2_unaligned_erms                                                                                                            ▒
+   10.38%     0.00%  deno_8597        libc-2.27.so           [.] __GI___libc_realloc (inlined)                                                                                                            ▒
+    9.26%     7.13%  deno_8597        libc-2.27.so           [.] _int_malloc                                                                                                                              ▒
+    8.73%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::fold_opt_block_stmt (inlined)                                                                                            ▒
+    8.73%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::Fold::fold_block_stmt (inlined)                                                                                          ▒
+    8.69%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::fold_stmt                                                                                                                ▒
+    8.69%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::Fold::fold_stmts                                                                                                         ▒
+    8.69%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::fold_stmts (inlined)                                                                                                     ▒
+    8.69%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <alloc::vec::Vec<T> as swc_visit::util::move_map::MoveMap<T>>::move_map (inlined)                                                        ▒
+    8.67%     0.09%  deno_8597        deno-8b0513ef89be7c6d  [.] <swc_ecma_transforms_react::jsx::Jsx<C> as swc_ecma_visit::Fold>::fold_expr                                                              ▒
+    8.67%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <swc_ecma_ast::expr::Expr as swc_ecma_visit::FoldWith<V>>::fold_children_with (inlined)                                                  ▒
+    8.67%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::fold_expr (inlined)                                                                                                      ▒
+    8.66%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::Fold::fold_opt_block_stmt (inlined)                                                                                      ▒
+    8.66%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::fold_block_stmt (inlined)                                                                                                ▒
+    8.63%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::fold_stmts::_$u7b$$u7b$closure$u7d$$u7d$::h05d391485415ccd4 (inlined)                                                    ▒
+    8.63%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::Fold::fold_stmt (inlined)                                                                                                ▒
+    8.36%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::Fold::fold_call_expr (inlined)                                                                                           ▒
+    8.36%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::fold_call_expr (inlined)

After using a vector

3.014 sec


+   93.02%     0.00%  deno_8597        [unknown]              [.] 0xffffffffffffffff                                                                                                                       ◆
+   49.84%    15.30%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::modules::sort::graph::StmtDepGraph::insert_transitives                                                             ▒
+   45.94%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] deno::bundle::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h33b13ccd96719fac                                              ▒
+   44.64%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::Bundler<L,R>::bundle (inlined)                                                                                     ▒
+   43.15%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::chunk::<impl swc_bundler::bundler::Bundler<L,R>>::chunk (inlined)                                                  ▒
+   40.73%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] scoped_tls::ScopedKey<T>::set (inlined)                                                                                                  ▒
+   40.72%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::Bundler<L,R>::run (inlined)                                                                                        ▒
+   40.61%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] core::iter::traits::iterator::Iterator::collect (inlined)                                                                                ▒
+   40.61%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <alloc::vec::Vec<T> as core::iter::traits::collect::FromIterator<T>>::from_iter (inlined)                                                ▒
+   40.61%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <alloc::vec::Vec<T> as alloc::vec::SpecFromIter<T,I>>::from_iter (inlined)                                                               ▒
+   40.61%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <alloc::vec::Vec<T> as alloc::vec::SpecFromIterNested<T,I>>::from_iter (inlined)                                                         ▒
+   40.54%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::Bundler<L,R>::run                                                                                                  ▒
+   40.54%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] scoped_tls::ScopedKey<T>::set (inlined)                                                                                                  ▒
+   40.54%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::chunk::merge::_$LT$impl$u20$swc_bundler..bundler..Bundler$LT$L$C$R$GT$$GT$::merge_modules::_$u7b$$u7b$closure$u7d$$▒
+   40.46%     0.02%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::chunk::merge::<impl swc_bundler::bundler::Bundler<L,R>>::finalize_merging_of_entry                                 ▒
+   39.92%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <alloc::vec::Vec<T,A> as alloc::vec::SpecExtend<T,I>>::spec_extend (inlined)                                                             ▒
+   39.92%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] core::iter::traits::iterator::Iterator::for_each (inlined)                                                                               ▒
+   39.92%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::fold (inlined)                                          ▒
+   39.92%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] core::iter::traits::iterator::Iterator::fold (inlined)                                                                                   ▒
+   39.92%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] core::iter::adapters::map::map_fold::_$u7b$$u7b$closure$u7d$$u7d$::h882e8545b9962f60 (inlined)                                           ▒
+   39.92%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::chunk::_$LT$impl$u20$swc_bundler..bundler..Bundler$LT$L$C$R$GT$$GT$::chunk::_$u7b$$u7b$closure$u7d$$u7d$::h5441d689▒
+   39.92%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::chunk::_$LT$impl$u20$swc_bundler..bundler..Bundler$LT$L$C$R$GT$$GT$::chunk::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7▒
+   39.92%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::chunk::merge::<impl swc_bundler::bundler::Bundler<L,R>>::merge_modules (inlined)                                   ▒
+   30.23%    29.57%  deno_8597        deno-8b0513ef89be7c6d  [.] std::collections::hash::set::HashSet<T,S>::insert                                                                                        ▒
+   25.30%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] deno::bundle                                                                                                                             ▒
+   25.30%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] testing::run_test2 (inlined)                                                                                                             ▒
+   25.30%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] scoped_tls::ScopedKey<T>::set (inlined)                                                                                                  ▒
+   25.30%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] testing::run_test2::_$u7b$$u7b$closure$u7d$$u7d$::h6361bf4a3fe8f6b8 (inlined)                                                            ▒
+   25.30%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] deno::bundle::_$u7b$$u7b$closure$u7d$$u7d$::h7702375601e5c80e (inlined)                                                                  ▒
+   25.30%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] scoped_tls::ScopedKey<T>::with (inlined)                                                                                                 ▒
+   24.91%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] deno::run                                                                                                                                ▒
+   21.08%    21.08%  deno_8597        libc-2.27.so           [.] __memcmp_sse4_1                                                                                                                          ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::modules::Modules::visit_mut_with (inlined)                                                                         ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <swc_ecma_ast::module::Module as swc_ecma_visit::VisitMutWith<V>>::visit_mut_with (inlined)                                              ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::VisitMut::visit_mut_module (inlined)                                                                                     ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::visit_mut_module (inlined)                                                                                               ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::VisitMut::visit_mut_module_items                                                                                         ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::visit_mut_module_items (inlined)                                                                                         ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <core::slice::iter::IterMut<T> as core::iter::traits::iterator::Iterator>::for_each (inlined)                                            ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::visit_mut_module_items::_$u7b$$u7b$closure$u7d$$u7d$::h82558f6695f323bd (inlined)                                        ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::VisitMut::visit_mut_module_item (inlined)                                                                                ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::visit_mut_module_item (inlined)                                                                                          ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::VisitMut::visit_mut_stmt (inlined)                                                                                       ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <swc_bundler::bundler::keywords::KeywordRenamer as swc_ecma_visit::VisitMut>::visit_mut_class_decl                                       ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::VisitMut::visit_mut_class                                                                                                ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::visit_mut_function                                                                                                       ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_ecma_visit::visit_mut_stmt                                                                                                           ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] <swc_bundler::bundler::keywords::KeywordRenamer as swc_ecma_visit::VisitMut>::visit_mut_expr                                             ▒
+   21.06%     0.00%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::keywords::KeywordRenamer::renamed                                                                                  ▒
+   19.80%     0.10%  deno_8597        deno-8b0513ef89be7c6d  [.] swc_bundler::bundler::modules::sort::<impl swc_bundler::bundler::modules::Modules>::sort                                                 ▒
+    9.15%     0.01%  deno_8597        deno-8b0513ef89be7c6d  [.] <swc_ecma_transforms_typescript::strip::Strip as swc_ecma_visit::VisitMut>::visit_mut_stmts                                              ▒
+    9.11%     8.61%  deno_8597        deno-8b0513ef89be7c6d  [.] <swc_ecma_transforms_typescript::strip::Strip as swc_ecma_visit::VisitMut>::visit_mut_expr                                               ▒

This reverts commit 1b9dafb.

This reverts commit a38d6d8.

This reverts commit 22067ef.

kdy1 added this to the v1.2.48 milestone Feb 8, 2021

kdy1 self-assigned this Feb 8, 2021

kdy1 force-pushed the bundler branch from 891fc8e to 1f3d0d9 Compare February 16, 2021 08:06

kdy1 added 27 commits February 19, 2021 15:42

Step 2 for denoland/deno#9350

185857d

fixup

6e25ba2

fixup

0cf21e2

Add a test for denoland/deno#9450

33a1140

fxhash

11260e0

Enable 8597

ebbef25

Use ahash

62d0996

WIP: faster graph

730d8b0

Add a test for denoland/deno#9464

cd9348e

Debug mode

d37d7f7

Don't sort if not required

bec24b8

Don't print

71dfd90

Use fast graph

236f87c

Enable aes

8d2ccb9

WIP: Use ahash

e52310a

fixup

d028e77

fixup

6b78be1

Use ahash

d085842

impl MapWithMut for more types.

77213d5

Optimize react pass.

ee7732f

Enable debug mode

64c52d9

Fixing tests

b44f966

Sort at proper step

34eeac2

Ignore one

9b428f6

Improve performance by replacing hashmap with a vector.

2922150

TRY: Sorting based on module dep graph

0de910f

fiixup

0e25524

kdy1 added 26 commits February 22, 2021 14:31

Reverse path correctly

09a103b

ㅕ

79ea389

Update test refs

2121417

Update test refs

65acaf0

inliner: Optimize shorthand props.

51f2263

Update test refs

627cb75

Create more variables for wrapped esms.

1b9dafb

Update test refs

57044f8

Revert "Create more variables for wrapped esms."

a38d6d8

This reverts commit 1b9dafb.

Revert "Revert "Create more variables for wrapped esms.""

2eb1814

This reverts commit a38d6d8.

More fine-grained rule for generating variables.

245b662

Optimize

fc2282b

[TRY]: synthesized_ctxt

22067ef

Revert "[TRY]: synthesized_ctxt"

9bca63c

This reverts commit 22067ef.

WIP: Fix 9200 by handling exports instead of variables

8f66b0d

FIx 9200

006036a

lints

d7eda08

Update test refs

013a646

[TRY]: Inject named export

ffda0d5

Fix 9200.

ea2997b

Update test refs

ff110e7

Fixed?

65d722d

lint

19997d6

Merge branch 'master' into bundler

7fcf10f

Bump version

ff4c6a4

Remove dbg

da1f184

kdy1 marked this pull request as ready for review February 22, 2021 08:20

kdy1 merged commit 7f5bfdc into swc-project:master Feb 22, 2021

kdy1 deleted the bundler branch February 22, 2021 08:27

swc-project locked as resolved and limited conversation to collaborators Nov 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(bundler): Fix bugs #1382

fix(bundler): Fix bugs #1382

kdy1 commented Feb 8, 2021 •

edited

Loading

fix(bundler): Fix bugs #1382

fix(bundler): Fix bugs #1382

Conversation

kdy1 commented Feb 8, 2021 • edited Loading

Issues

Tasks

Performance

Initial time for 8597

After using fxhash while sorting

After using ahash and faster graph

After using a vector

kdy1 commented Feb 8, 2021 •

edited

Loading