Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Node.js addon binary size #1418

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Reduce Node.js addon binary size #1418

merged 1 commit into from
Feb 20, 2021

Conversation

Brooooooklyn
Copy link
Member

No description provided.

kdy1
kdy1 approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Cargo.toml
@@ -1,3 +1,5 @@
cargo-features = ["strip"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I didn't know this. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a nightly feature in Cargo: rust-lang/cargo#8246

@Brooooooklyn Brooooooklyn marked this pull request as ready for review February 20, 2021 07:25
@kdy1 kdy1 added this to the v1.2.48 milestone Feb 20, 2021
@kdy1 kdy1 self-assigned this Feb 20, 2021
@kdy1 kdy1 merged commit 9d896c7 into swc-project:master Feb 20, 2021
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.2.48
Development

Successfully merging this pull request may close these issues.
2 participants
@Brooooooklyn @kdy1