fix(strip): Combine typescript_class_properties() into strip() #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
commented
Mar 19, 2021
Comment on lines
223
to
225
| // TODO(nayeemrmn): Static fields should also be moved to | ||
| // assignments after the class. Figure out how. They are | ||
| // preserved for now. |
There was a problem hiding this comment.
I need to be able to move the static class fields here to assignments after the class.
Comment on lines
+751
to
+752
| // TODO(nayeemrmn): This output should be achieved without | ||
| // `typescript_class_properties()`. |
|
Sorry for late response. I was too busy because of other projects. The changes seems ok to me. But I have a question. |
Not totally sure what you mean by "when target < es2020", but any change in behaviour is non-breaking and aligns with tsc. The behaviour of |
|
@nayeemrmn Thank you very much for the pr and clarification :) |
kdy1
added a commit
to kdy1/swc
that referenced
this pull request
Mar 31, 2021
…roject#1478) swc_ecma_utils: - Use `&mut` for inject_after_super. swc_ecma_transforms_typescript: - Merge `typescript_class_properties` into `strip`. Co-authored-by: 강동윤 <kdy1997.dev@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kdy1 This implements
use_define_for_class_fields: trueas correctly specified in #1472. It also adds the behaviour of thetypescript_class_properties()pass directly intostrip()in case ofuse_define_for_class_fields: false. This aligns with tsc. Thetypescript_class_properties()is redundant and should be removed.However, I can't figure out how to copy the static class field handling from
typescript_class_fields()tostrip(). So I left some TODOs and haven't removed it yet. Help would be appreciated.