Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecma/transform/typescript): remove import used in interface and type signature #3893

Merged
merged 2 commits into from
Mar 7, 2022
Merged

fix(ecma/transform/typescript): remove import used in interface and type signature #3893

merged 2 commits into from
Mar 7, 2022

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Mar 7, 2022

Description:
The other part of #3827

BREAKING CHANGE:

Related issue (if exists):

kdy1
kdy1 approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I didn't get it fully, but it works :P

swc-bump:

  • swc_ecma_transforms_typescript

@kdy1 kdy1 added this to the v1.2.152 milestone Mar 7, 2022
@Austaras
Copy link
Member Author

Austaras commented Mar 7, 2022

Visit is only used to strip type only import, which means it only need to know if a import is referred in a value context, so the impl can be simplified to skip all idents in type context.

@kdy1 kdy1 merged commit 5c92b2d into swc-project:main Mar 7, 2022
@Austaras Austaras mentioned this pull request Mar 10, 2022
Closed
@Jordan-Hall Jordan-Hall mentioned this pull request Mar 10, 2022
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.152
Development

Successfully merging this pull request may close these issues.
2 participants
@Austaras @kdy1