Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/parser): typeof on #private Fields #4302

Merged
merged 4 commits into from
Apr 11, 2022
Merged

feat(es/parser): typeof on #private Fields #4302

merged 4 commits into from
Apr 11, 2022

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Apr 11, 2022 •
edited
Loading

Description:

BREAKING CHANGE:

  • swc_ecma_ast
  • swc_ecma_codegen
  • swc_ecma_parser
  • swc_ecma_transforms_proposal
  • swc_ecma_transforms_typescript
  • swc_ecma_visit
  • swc_estree_ast
  • swc_estree_compat

Related issue (if exists):

@magic-akari magic-akari marked this pull request as ready for review April 11, 2022 15:40
kdy1
kdy1 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_ast --breaking
  • swc_estree_ast --breaking

@kdy1 kdy1 added this to the v1.2.166 milestone Apr 11, 2022
@kdy1 kdy1 enabled auto-merge (squash) April 11, 2022 19:41
@kdy1 kdy1 merged commit d0de5a6 into swc-project:main Apr 11, 2022
@magic-akari magic-akari deleted the feat/private-type-query branch May 3, 2022 05:11
@jakebailey
Copy link

We're reverting the linked change in TS, so you probably want to revert it too.

@kdy1 kdy1 mentioned this pull request May 5, 2022
Merged
williamtetlow added a commit to williamtetlow/swc that referenced this pull request May 5, 2022
@williamtetlow
Revert "feat(es): Support typeof with private fields (swc-project#4302
7db53a3 
)"

This reverts commit d0de5a6.
@williamtetlow williamtetlow mentioned this pull request May 5, 2022
Merged
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.166
Development

Successfully merging this pull request may close these issues.

TypeScript - Support typeof on private fields
3 participants
@magic-akari @jakebailey @kdy1