Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/codegen): Align sourcemap with terser #5657

Merged
merged 228 commits into from
Sep 26, 2022
Merged

fix(es/codegen): Align sourcemap with terser #5657

merged 228 commits into from
Sep 26, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 29, 2022 •
edited
Loading

Description:

I know this is an insance work and a hard word at the same time, but ensuring sourcemap is inherently hard task

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Aug 29, 2022
@kdy1 kdy1 force-pushed the srcmap branch 2 times, most recently from 19b756e to d879bed Compare August 29, 2022 10:13
@kdy1 kdy1 force-pushed the srcmap branch 4 times, most recently from 04bddb0 to 7a68232 Compare September 21, 2022 07:24
@kdy1 kdy1 changed the title fix(es/codegen): Align sourcemap with babel code generator fix(es/codegen): Align sourcemap with terser Sep 21, 2022
kdy1
kdy1 commented Sep 26, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_common
  • swc_ecma_codegen

@kdy1 kdy1 marked this pull request as ready for review September 26, 2022 08:26
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 26, 2022
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) September 26, 2022 08:26
@kdy1 kdy1 disabled auto-merge September 26, 2022 09:12
@kdy1 kdy1 merged commit 2ba8815 into swc-project:main Sep 26, 2022
@kdy1 kdy1 deleted the srcmap branch September 26, 2022 09:12
@kdy1 kdy1 modified the milestones: Planned, v1.3.4 Sep 30, 2022
@shiftkey shiftkey mentioned this pull request Oct 24, 2022
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.4
1 participant
@kdy1