Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - regenerator: allow nested finally block #601

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - regenerator: allow nested finally block #601

wants to merge 14 commits into from
+125 −16

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 23, 2020

Previously,

function *foo() {
    try {
    } finally {
        try {
        } finally {
             throw new Error('foo');
        }
    }
}

make swc panic

Closes #600.

@kdy1 kdy1 added this to the v1.1.14 milestone Jan 23, 2020
@kdy1
Copy link
Member Author

kdy1 commented Jan 23, 2020

bors r+

bors bot pushed a commit that referenced this pull request Jan 23, 2020
@kdy1
regenerator: allow nested finally block (#601)
20e37ea 
Previously, 

```js
function *foo() {
    try {
    } finally {
        try {
        } finally {
             throw new Error('foo');
        }
    }
}

```

make swc panic

Closes #600.
@bors
Copy link
Contributor

bors bot commented Jan 23, 2020

Build succeeded

  • continuous-integration/travis-ci/push

@bors
Copy link
Contributor

bors bot commented Jan 23, 2020

Pull request successfully merged into master.

@bors bors bot changed the title regenerator: allow nested finally block [Merged by Bors] - regenerator: allow nested finally block Jan 23, 2020
@bors bors bot closed this Jan 23, 2020
@kdy1 kdy1 deleted the issue-600 branch January 27, 2020 04:28
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v1.1.14
Development

Successfully merging this pull request may close these issues.

Panic on 'for .. of' loop in async function
1 participant
@kdy1