Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Don't drop assignments to unused top-level variables #7581

Merged
merged 11 commits into from
Jun 27, 2023
Merged

fix(es/minifier): Don't drop assignments to unused top-level variables #7581

merged 11 commits into from
Jun 27, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 26, 2023

@kdy1 kdy1 added this to the Planned milestone Jun 26, 2023
@kdy1 kdy1 self-assigned this Jun 26, 2023
@kdy1 kdy1 marked this pull request as ready for review June 26, 2023 02:15
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 26, 2023
View reviewed changes
@kdy1 kdy1 requested a review from jridgewell June 26, 2023 02:15
@kdy1 kdy1 changed the title fix(es/minifier): Don't drop unused top-level variables fix(es/minifier): Don't drop assignments to unused top-level variables Jun 26, 2023
kdy1
kdy1 commented Jun 26, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_usage_analyzer

@kdy1 kdy1 enabled auto-merge (squash) June 27, 2023 01:12
@kdy1 kdy1 dismissed stale reviews from jridgewell and kodiakhq[bot] via 6e0409a June 27, 2023 01:12
swc-bot
swc-bot reviewed Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit a685c88 into swc-project:main Jun 27, 2023
@kdy1 kdy1 deleted the issue-7568 branch June 27, 2023 15:24
@kdy1 kdy1 modified the milestones: Planned, v1.3.67 Jun 29, 2023
@Austaras Austaras mentioned this pull request Jul 18, 2023
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

@jridgewell jridgewell jridgewell left review comments

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.67
Development

Successfully merging this pull request may close these issues.

SWC minify and webpack DLL/Federation interoperability issues
3 participants
@kdy1 @jridgewell @swc-bot